commit | 2d5ee50bb220378f47afb88f6d6fb752fbd30f9b | [log] [tgz] |
---|---|---|
author | Vikash Chandola <vikash.chandola@intel.com> | Thu Jul 06 15:57:09 2023 +0530 |
committer | Vikash Chandola <vikash.chandola@intel.com> | Wed Jul 12 12:28:37 2023 +0530 |
tree | ec26846dfab11784cdc685efb487a16c9edecc55 | |
parent | c54f6c5b923f18d118f31fbfb8bb016812a7a29f [diff] |
Avoid thresholds vector update while iterating new data is pushed on thresholds vector while it is being iterated. vector insertion can resize vector length. Resize in vector cause invalidation of iterators and further operation iterator is undefined behaviour(i.e. crash). Iterate through vector by indexing it from beginning to original size. Tested: No cashes were observed with thresholds vector iteration. Change-Id: Idf1d017847fa77128922a38eb6e33e0fa5702f3d Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name> Interfaces xyz.openbmc_project.Sensor.Value xyz.openbmc_project.Sensor.Threshold.Critical xyz.openbmc_project.Sensor.Threshold.Warning xyz.openbmc_project.State.Decorator.Availability xyz.openbmc_project.State.Decorator.OperationalStatus xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.