| commit | 4cd5a90bad356f17d5bdb289b2d67a9961ceb2ea | [log] [tgz] |
|---|---|---|
| author | Wang Xiaohua <wangxiaohua.1217@bytedance.com> | Tue Jul 04 16:28:43 2023 +0800 |
| committer | Zhikui Ren <zhikui.ren@intel.com> | Thu Aug 10 13:53:32 2023 -0700 |
| tree | 234a374afee2239068a83d702ad81612c976809d | |
| parent | 75f925870dd4684066b2bfabca2c29399d5ccd5e [diff] |
intelcpusensor:always unlock peci fd in detectCPU Currently, intelcpusensor can leave peci fd locked after detectCPU call. This causes lock to fail for the next detectCPU call. It also can cause kernel issues, when driver is unbound and application keeps the file open (since peci_unlock is not called it keeps) - the kernel structures remain in memory. Which means, that on application stop (during reboot or for any reason) the kernel warnings/errors will appear. Tested: intelcpusensor journal log does not have below error message anymore "intelcpusensor[31213]: PECI device failed to unlock." Change-Id: Ib2e7682d5f9a25124aeb340cc5cdb5375b4d773d Signed-off-by: Wang Xiaohua <wangxiaohua.1217@bytedance.com> Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.