| commit | 58e02efa73d5511c603a327b9a6760931a03d66e | [log] [tgz] |
|---|---|---|
| author | Adrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com> | Thu Aug 06 14:42:38 2020 +0200 |
| committer | Adrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com> | Thu Aug 13 07:26:49 2020 +0000 |
| tree | 42270bc09bafb3aac48a592f6846db8ebbc8b2c2 | |
| parent | 8b8bcc8700af5ba1d435c7cf0f6467b2b6a8c679 [diff] |
Fix detection of invalid 'GetSensorReading' This change fixes incorrect way to determine Get Sensor Reading value availability. In previous implementation proper value of '0' was treated as error. IPMI spec defines 'reading/state unavailable' bit, which ME uses to inform user about sensor reading being absent. This change monitors that bit to determine outcome of Get Sensor Reading call. Alternative considered was to also look at 'sensor scanning disabled', but after reading more documentation and checking ME implementation it turns out that it affects only threshold events generation. Testing: - verified that 'nan' is set for unavailable sensor (PSU with PMBUS cable cut-off) - verified that for available sensor reporting '0', '0' value is present instead of 'nan' Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com> Change-Id: Iaa940b808e36b9606fe78f7cef7bab2593275889
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access