commit	5d032bc24ca174096e92816155ef773d4f80c734	[log] [tgz]
author	Kumar Thangavel <thangavel.k@hcl.com>	Wed Nov 30 20:24:47 2022 +0530
committer	Zhikui Ren <zhikui.ren@intel.com>	Fri Mar 03 22:34:30 2023 +0000
tree	b801388ea8a33b1cc237375cd500a057df924d46
parent	8a28bf11b0064224393b880fdcdc7423ef817106 [diff]

Add support for slot hot plug/unplug of sdr sensors

Added support for slot hot plug/unplug of sdr sensors in
dbus-sensors and IpmbSensor dbus tree updated accordingly

TESTED : Verified hot plug/unplug of all hosts sdr sensors
are enabled and tested in Facebook YosemiteV2 platform

Test case 1 : hot unplugged/removed host1

root@yosemitev2:~# busctl tree xyz.openbmc_project.IpmbSensor
`-/xyz
  `-/xyz/openbmc_project/sensors
    |-/xyz/openbmc_project/sensors/current
    | |-/xyz/openbmc_project/sensors/current/2_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVDDQ_DE_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/2_PVNN_PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVDDQ_DE_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVNN_PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVDDQ_DE_VR_Curr
    | `-/xyz/openbmc_project/sensors/current/4_PVNN_PCH_VR_Curr

Test case 2 : hot unplugged/removed host2

root@yosemitev2:~# busctl tree xyz.openbmc_project.IpmbSensor
`-/xyz
  `-/xyz/openbmc_project/sensors
    |-/xyz/openbmc_project/sensors/current
    | |-/xyz/openbmc_project/sensors/current/1_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVDDQ_DE_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/1_PVNN_PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVDDQ_DE_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/3_PVNN_PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_P1V05PCH_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCIN_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCIO_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVCCSA_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVDDQ_AB_VR_Curr
    | |-/xyz/openbmc_project/sensors/current/4_PVDDQ_DE_VR_Curr
    | `-/xyz/openbmc_project/sensors/current/4_PVNN_PCH_VR_Curr

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I1ac62c0ac374004b33104e2d4fb0d743d76b83b9

src/IpmbSensor.cpp[diff]

1 file changed

tree: b801388ea8a33b1cc237375cd500a057df924d46

README.md

dbus-sensors

dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.

key features

runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access

dbus interfaces

A typical dbus-sensors object support the following dbus interfaces:

Path        /xyz/openbmc_project/sensors/<type>/<sensor_name>

Interfaces  xyz.openbmc_project.Sensor.Value
            xyz.openbmc_project.Sensor.Threshold.Critical
            xyz.openbmc_project.Sensor.Threshold.Warning
            xyz.openbmc_project.State.Decorator.Availability
            xyz.openbmc_project.State.Decorator.OperationalStatus
            xyz.openbmc_project.Association.Definitions

Sensor interfaces collection are described here.

Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.

Reactor

dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.

Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.

A simple sensor example can be found here.

configuration

Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.

sensor documentation

ExternalSensor virtual sensor