commit 72b3911656bebd8140831a71033bf9880cf92472
author Ed Tanous <ed@tanous.net> Wed Apr 03 18:35:24 2024 -0700
committer Ed Tanous <ed@tanous.net> Wed Apr 03 18:38:20 2024 -0700
tree d7c5ad85e7880e7ccb8c5a0d05fcb865a2b3162f
parent 201a10157c0add72a2aac484da3d82220d545714

Enable bugprone-assignment-in-if-condition

And fix the one violation.

Change-Id: I8b844d0e987827527c82e3351efd40c1bfd692db
Signed-off-by: Ed Tanous <ed@tanous.net>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index da851c0..92c35a8 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -2,6 +2,7 @@
 -*,
 boost-use-to-string,
 bugprone-argument-comment,
+bugprone-assignment-in-if-condition,
 bugprone-assert-side-effect,
 bugprone-bad-signal-to-kill-thread,
 bugprone-bool-pointer-implicit-conversion,

src/NVMeBasicContext.cpp

diff --git a/src/NVMeBasicContext.cpp b/src/NVMeBasicContext.cpp
index 032e68a..527605c 100644
--- a/src/NVMeBasicContext.cpp
+++ b/src/NVMeBasicContext.cpp
@@ -226,9 +226,9 @@
 
     thread = std::jthread([streamIn{std::move(streamIn)},
                            streamOut{std::move(streamOut)}]() mutable {
-        ssize_t rc = 0;
+        ssize_t rc = processBasicQueryStream(streamIn, streamOut);
 
-        if ((rc = processBasicQueryStream(streamIn, streamOut)) < 0)
+        if (rc < 0)
         {
             std::cerr << "Failure while processing query stream: "
                       << strerror(static_cast<int>(-rc)) << "\n";