commit 89be6147e5a7ffa86d88d8f3e27eba8eb2c3a9da
author Alexander Hansen <alexander.hansen@9elements.com> Thu Sep 18 15:36:16 2025 +0200
committer Alexander Hansen <alexander.hansen@9elements.com> Mon Oct 06 15:33:10 2025 +0200
tree e2c9b431414823c46aea3c1d72c31346d43e8333
parent 0662e607425838f3321aa13e25c718813fddec97

src: remove bool debug

Follow-up commit to the lg2 conversion.

Patching is not needed to get debug logs with lg2.

Tested: Inspection only.

Change-Id: Ie44b2debc7f4dff3a431a15f53720ae2da044a68
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

src/Thresholds.cpp

diff --git a/src/Thresholds.cpp b/src/Thresholds.cpp
index 2489fc8..f46fd46 100644
--- a/src/Thresholds.cpp
+++ b/src/Thresholds.cpp
@@ -26,7 +26,6 @@
 #include <variant>
 #include <vector>
 
-static constexpr bool debug = false;
 namespace thresholds
 {
 Level findThresholdLevel(uint8_t sev)
@@ -325,15 +324,12 @@
     if (cDebugThrottle >= 1000)
     {
         cDebugThrottle = 0;
-        if constexpr (debug)
-        {
-            lg2::error("checkThresholds: High T= {HIGH_TRUE}, F= {HIGH_FALSE},"
-                       " M= {HIGH_MIDSTATE}, Low T= {LOW_TRUE}, F= {LOW_FALSE},"
-                       " M= {LOW_MIDSTATE}",
-                       "HIGH_TRUE", cHiTrue, "HIGH_FALSE", cHiFalse,
-                       "HIGH_MIDSTATE", cHiMidstate, "LOW_TRUE", cLoTrue,
-                       "LOW_FALSE", cLoFalse, "LOW_MIDSTATE", cLoMidstate);
-        }
+        lg2::debug("checkThresholds: High T= {HIGH_TRUE}, F= {HIGH_FALSE},"
+                   " M= {HIGH_MIDSTATE}, Low T= {LOW_TRUE}, F= {LOW_FALSE},"
+                   " M= {LOW_MIDSTATE}",
+                   "HIGH_TRUE", cHiTrue, "HIGH_FALSE", cHiFalse,
+                   "HIGH_MIDSTATE", cHiMidstate, "LOW_TRUE", cLoTrue,
+                   "LOW_FALSE", cLoFalse, "LOW_MIDSTATE", cLoMidstate);
     }
 
     return thresholdChanges;
@@ -528,11 +524,8 @@
                 if (auto val = readFile(attrPath, scaleFactor))
                 {
                     *val += offset;
-                    if (debug)
-                    {
-                        lg2::info("Threshold: '{PATH}': '{VALUE}'", "PATH",
-                                  attrPath, "VALUE", *val);
-                    }
+                    lg2::debug("Threshold: '{PATH}': '{VALUE}'", "PATH",
+                               attrPath, "VALUE", *val);
                     thresholdVector.emplace_back(level, direction, *val,
                                                  hysteresis);
                 }