commit 89be6147e5a7ffa86d88d8f3e27eba8eb2c3a9da
author Alexander Hansen <alexander.hansen@9elements.com> Thu Sep 18 15:36:16 2025 +0200
committer Alexander Hansen <alexander.hansen@9elements.com> Mon Oct 06 15:33:10 2025 +0200
tree e2c9b431414823c46aea3c1d72c31346d43e8333
parent 0662e607425838f3321aa13e25c718813fddec97

src: remove bool debug

Follow-up commit to the lg2 conversion.

Patching is not needed to get debug logs with lg2.

Tested: Inspection only.

Change-Id: Ie44b2debc7f4dff3a431a15f53720ae2da044a68
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

src/intrusion/ChassisIntrusionSensor.cpp

diff --git a/src/intrusion/ChassisIntrusionSensor.cpp b/src/intrusion/ChassisIntrusionSensor.cpp
index 445adbe..3103ff5 100644
--- a/src/intrusion/ChassisIntrusionSensor.cpp
+++ b/src/intrusion/ChassisIntrusionSensor.cpp
@@ -49,8 +49,6 @@
 #include <linux/i2c-dev.h>
 }
 
-static constexpr bool debug = false;
-
 static constexpr unsigned int defaultPollSec = 1;
 static constexpr unsigned int sensorFailedPollSec = 5;
 static unsigned int intrusionSensorPollSec = defaultPollSec;
@@ -83,11 +81,8 @@
         return;
     }
 
-    if constexpr (debug)
-    {
-        lg2::info("Update value from '{VALUE}' to '{NEWVALUE}'", "VALUE",
-                  mValue, "NEWVALUE", newValue);
-    }
+    lg2::debug("Update value from '{VALUE}' to '{NEWVALUE}'", "VALUE", mValue,
+               "NEWVALUE", newValue);
 
     // Automatic Rearm mode allows direct update
     // Manual Rearm mode requires a rearm action to clear the intrusion
@@ -128,10 +123,7 @@
     int32_t statusReg = pchStatusRegIntrusion;
 
     int32_t value = i2c_smbus_read_byte_data(mBusFd, statusReg);
-    if constexpr (debug)
-    {
-        lg2::info("Pch type: raw value is '{VALUE}'", "VALUE", value);
-    }
+    lg2::debug("Pch type: raw value is '{VALUE}'", "VALUE", value);
 
     if (value < 0)
     {
@@ -142,10 +134,7 @@
     // Get status value with mask
     value &= statusMask;
 
-    if constexpr (debug)
-    {
-        lg2::info("Pch type: masked raw value is '{VALUE}'", "VALUE", value);
-    }
+    lg2::debug("Pch type: masked raw value is '{VALUE}'", "VALUE", value);
     return value;
 }
 
@@ -191,10 +180,7 @@
 {
     mGpioLine.event_read();
     auto value = mGpioLine.get_value();
-    if constexpr (debug)
-    {
-        lg2::info("Gpio type: raw value is '{VALUE}'", "VALUE", value);
-    }
+    lg2::debug("Gpio type: raw value is '{VALUE}'", "VALUE", value);
     return value;
 }
 
@@ -246,10 +232,7 @@
     try
     {
         value = std::stoi(line);
-        if constexpr (debug)
-        {
-            lg2::info("Hwmon type: raw value is '{VALUE}'", "VALUE", value);
-        }
+        lg2::debug("Hwmon type: raw value is '{VALUE}'", "VALUE", value);
     }
     catch (const std::invalid_argument& e)
     {
@@ -464,12 +447,9 @@
     // Expecting only one hwmon file for one given chassis
     mHwmonPath = paths[0].string();
 
-    if constexpr (debug)
-    {
-        lg2::info(
-            "Found '{NUM_PATHS}' paths for intrusion status. The first path is: '{PATH}'",
-            "NUM_PATHS", paths.size(), "PATH", mHwmonPath);
-    }
+    lg2::debug(
+        "Found '{NUM_PATHS}' paths for intrusion status. The first path is: '{PATH}'",
+        "NUM_PATHS", paths.size(), "PATH", mHwmonPath);
 }
 
 ChassisIntrusionSensor::~ChassisIntrusionSensor()