Make dbus-sensors compile with clang-13
clang-13 finds a lot more warnings for unused variables than it used to,
and also picks up some warnings about errant std::moves that are in
place.
This commit fixes them.
Tested:
code compiles against clang-13
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I80864287b7131acfe936c4b28afaf34ababb3029
diff --git a/src/FanMain.cpp b/src/FanMain.cpp
index 465ce1b..cb0afd3 100644
--- a/src/FanMain.cpp
+++ b/src/FanMain.cpp
@@ -39,8 +39,6 @@
#include <variant>
#include <vector>
-static constexpr bool debug = false;
-
namespace fs = std::filesystem;
// The following two structures need to be consistent
@@ -163,9 +161,8 @@
{
auto getter = std::make_shared<GetSensorConfiguration>(
dbusConnection,
- std::move([&io, &objectServer, &tachSensors, &pwmSensors,
- &dbusConnection, sensorsChanged](
- const ManagedObjectType& sensorConfigurations) {
+ [&io, &objectServer, &tachSensors, &pwmSensors, &dbusConnection,
+ sensorsChanged](const ManagedObjectType& sensorConfigurations) {
bool firstScan = sensorsChanged == nullptr;
std::vector<fs::path> paths;
if (!findFiles(fs::path("/sys/class/hwmon"), R"(fan\d+_input)",
@@ -448,7 +445,7 @@
}
createRedundancySensor(tachSensors, dbusConnection, objectServer);
- }));
+ });
getter->getConfiguration(
std::vector<std::string>{sensorTypes.begin(), sensorTypes.end()},
retries);