Standardize read errors
Each sensor handled read errors their own way,
making it inconsistant. This helps to align them all
in the base class, so that error handling happens the
same for each sensor. It also aligns the power state
change handling.
Tested: Tested DC Cycling and Enabling/Disabling ME to
make sure functional change correctly
Change-Id: I1a191d27629602e1ca3871d933af07b15bf9f331
Signed-off-by: James Feist <james.feist@linux.intel.com>
diff --git a/include/IpmbSensor.hpp b/include/IpmbSensor.hpp
index 3d78bfa..e1b1ddb 100644
--- a/include/IpmbSensor.hpp
+++ b/include/IpmbSensor.hpp
@@ -52,8 +52,7 @@
void init(void);
void loadDefaults(void);
void runInitCmd(void);
- void processError(void);
- double processReading(const std::vector<uint8_t>& data);
+ bool processReading(const std::vector<uint8_t>& data, double& resp);
IpmbType type;
IpmbSubType subType;
@@ -68,8 +67,6 @@
std::optional<uint8_t> initCommand;
std::vector<uint8_t> initData;
- // to date all ipmb sensors are power on only
- PowerState readState;
ReadingFormat readingFormat;
private: