| commit | ae4639667132e9bca62277815f0dca5c77c0b887 | [log] [tgz] |
|---|---|---|
| author | Zhikui Ren <zhikui.ren@intel.com> | Tue Jan 02 15:35:31 2024 -0800 |
| committer | Zhikui Ren <zhikui.ren@intel.com> | Thu Jan 04 16:28:37 2024 +0000 |
| tree | 387d75907acd2d793c5e58910792a0508911aebf | |
| parent | 0df80a1defa16686bc9ac3f61c2cd87b6ab60219 [diff] |
hwmontempsensor: Handle failure to canonicalize device path std::filestream::canonical(const std::filesystem::path& p) can throw exception if the path does not exist. hwmontempsensor would crash with: what(): filesystem error: cannot make canonical path: No such file or directory [/sys/class/hwmon/hwmon38/device] Replace with canonical(const std::filesystem::path& p, std::error_code& ec) which captures error code without exception. This call still may throw std::bad_alloc if memory allocation fails. But there is no good way to resolve system OOM from this service, leave it unhandled and let the service exit. Tested: Same hwmontemp sensors are created with the change. Signed-off-by: Zhikui Ren <zhikui.ren@intel.com> Change-Id: I0cf98950faf44b35dc71387a653ba1feeb375cc1
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.