commit b074528654b0f2f9b52d897d0d85c542dcd2566b
author Ed Tanous <ed@tanous.net> Wed Apr 03 18:57:45 2024 -0700
committer Andrew Jeffery <andrew@codeconstruct.com.au> Fri Apr 05 01:07:06 2024 +0000
tree 576e3155905d23c713b64bc1e1d73579b84d2c26
parent 739ab19f24e0be06af9e4fe750b28c7ef530186e

Add bugprone-optional-value-conversion

And fix the one case.

Change-Id: Iaaedf56b12cae38583ae82017ebea8bfe8987689
Signed-off-by: Ed Tanous <ed@tanous.net>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index fb31ead..46561c1 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -26,6 +26,7 @@
 bugprone-misplaced-widening-cast,
 bugprone-move-forwarding-reference,
 bugprone-multiple-statement-macro,
+bugprone-optional-value-conversion,
 bugprone-no-escape,
 bugprone-not-null-terminated-result,
 bugprone-parent-virtual-call,

src/NVMeSensorMain.cpp

diff --git a/src/NVMeSensorMain.cpp b/src/NVMeSensorMain.cpp
index 5287504..81be2eb 100644
--- a/src/NVMeSensorMain.cpp
+++ b/src/NVMeSensorMain.cpp
@@ -93,7 +93,7 @@
 
     if (!std::filesystem::is_symlink(muxPath))
     {
-        return *busNumber;
+        return busNumber;
     }
 
     std::string rootName = std::filesystem::read_symlink(muxPath).filename();