Turn on a bunch of warnings
Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Tested:
ipmitool sensor list still works
Change-Id: Ied8fa66de9fcd25e448f8048c4f8216b426b6f55
Signed-off-by: James Feist <james.feist@linux.intel.com>
diff --git a/src/HwmonTempMain.cpp b/src/HwmonTempMain.cpp
index 2b1d7c1..7eaea30 100644
--- a/src/HwmonTempMain.cpp
+++ b/src/HwmonTempMain.cpp
@@ -79,7 +79,7 @@
continue; // already searched this path
}
- auto device = fs::path(directory / "device");
+ fs::path device = directory / "device";
std::string deviceName = fs::canonical(device).stem();
auto findHyphen = deviceName.find("-");
if (findHyphen == std::string::npos)
@@ -97,7 +97,7 @@
bus = std::stoi(busStr);
addr = std::stoi(addrStr, 0, 16);
}
- catch (std::invalid_argument)
+ catch (std::invalid_argument&)
{
continue;
}
@@ -208,7 +208,7 @@
}
}
-int main(int argc, char** argv)
+int main()
{
boost::asio::io_service io;
auto systemBus = std::make_shared<sdbusplus::asio::connection>(io);