| commit | bcb062a07898594b0dae8f0b961bfee7875cd16f | [log] [tgz] |
|---|---|---|
| author | Matt Simmering <matthew.simmering@intel.com> | Wed Dec 13 15:13:03 2023 -0800 |
| committer | Zhikui Ren <zhikui.ren@intel.com> | Fri Jan 19 02:21:05 2024 +0000 |
| tree | faae313def53ef67f886ce576a105e2024e45388 | |
| parent | 6e6561d6bd693fdb138c131ee811aabc982e4efc [diff] |
Set exitAirSensor to null before creating sensor If the configuration for the current ExitAirTempSensor is changed the service will crash because it will re-create its DBus interfaces. To prevent this set exitAirSensor to nullptr before creating a new sensor. Tested: Change a property of the ExitAirTempSensor to something new to re-trigger createSensors(), e.g. busctl set-property xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/chassis/R4000_Chassis/Exit_Air_Temp xyz.openbmc_project.Configuration.ExitAirTempSensor.Thresholds0 Value d 93 Without the fix the service would crash: with the error: "exitairtempsensor: what(): sd_bus_add_object_vtable: org.freedesktop.DBus.Error.FileExists: File exists". With the fix the service doesn't crash and the property change holds. Change-Id: I288140a8bd7ebb7119726720e0c829f3677a8aca Signed-off-by: Matt Simmering <matthew.simmering@intel.com>
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.