Set exitAirSensor to null before creating sensor
If the configuration for the current ExitAirTempSensor is changed the
service will crash because it will re-create its DBus interfaces. To
prevent this set exitAirSensor to nullptr before creating a new sensor.
Tested:
Change a property of the ExitAirTempSensor to something new to
re-trigger createSensors(), e.g.
busctl set-property xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/R4000_Chassis/Exit_Air_Temp
xyz.openbmc_project.Configuration.ExitAirTempSensor.Thresholds0 Value d 93
Without the fix the service would crash:
with the error: "exitairtempsensor: what(): sd_bus_add_object_vtable:
org.freedesktop.DBus.Error.FileExists: File exists". With the fix the
service doesn't crash and the property change holds.
Change-Id: I288140a8bd7ebb7119726720e0c829f3677a8aca
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>
diff --git a/src/ExitAirTempSensor.cpp b/src/ExitAirTempSensor.cpp
index f235c26..59180b5 100644
--- a/src/ExitAirTempSensor.cpp
+++ b/src/ExitAirTempSensor.cpp
@@ -873,6 +873,7 @@
parseThresholdsFromConfig(interfaces, sensorThresholds);
std::string name = loadVariant<std::string>(cfg, "Name");
+ exitAirSensor = nullptr;
exitAirSensor = std::make_shared<ExitAirTempSensor>(
dbusConnection, name, path.str, objectServer,
std::move(sensorThresholds));