| commit | d0c21d554b037a54736cd439848d562549c6bd6c | [log] [tgz] |
|---|---|---|
| author | Matt Spinler <spinler@us.ibm.com> | Thu Nov 17 13:55:48 2022 -0600 |
| committer | Zhikui Ren <zhikui.ren@intel.com> | Sun Dec 11 23:05:38 2022 +0000 |
| tree | c686ccfd04bac995268a395af843a14cd89e36f2 | |
| parent | 1f847973052186e08245737f1241669240f7407c [diff] |
adcsensor: Use unique timer for CPU pres events If a CPU Present property changes within 1 second of a normal ADC sensor config being put on D-Bus by entity-manager for the first time, the single filter timer being used will only call createSensors once. That sensor will then be ignored since that call to createSensors is only looking for CPU required sensors. To fix this, add a separate filter timer for CPU presence changes. That way the standard ADC sensors will get a chance to be processed in a createSensors call using UpdateType::init. Tested: Our IBM systems would hit this issue a lot because there are a lot of inventory items with 'cpu' in the name so there are a lot of calls to cpuPresenceHandler. With this fix, the RTC battery voltage sensor would always be created after a reboot. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Id33587f7b3c9bf29c6e92f64c283b8659293c851
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.