commit e330c0c1feedc765f8bef3fc0215c764e43bfc5c
author Hao Jiang <jianghao@google.com> Tue Sep 06 23:59:41 2022 +0000
committer Ed Tanous <ed@tanous.net> Sun Sep 11 16:44:18 2022 +0000
tree c21a04abfe80273b0712769c62d994de57474c80
parent 9c47bd7ed57ae332cddbc7d06c58b76315d09722

FileHandle: only close on valid fd

When fd < 0, we didn't open the fd given the fd is invalid. So we won't
need to close the fd as well. The current implement prints false alarm
on move constructer/assignment.

Signed-off-by: Hao Jiang <jianghao@google.com>
Change-Id: Ib6e0227fd1ba865ca037e8e5f8d1fc0dcc304185

src/FileHandle.cpp

diff --git a/src/FileHandle.cpp b/src/FileHandle.cpp
index c77fc3d..af32192 100644
--- a/src/FileHandle.cpp
+++ b/src/FileHandle.cpp
@@ -34,7 +34,7 @@
 
 FileHandle::~FileHandle()
 {
-    if (fd != 0)
+    if (fd >= 0)
     {
         int r = close(fd);
         if (r < 0)