Deassert thresholds when sensor is unavailable

Some dbus-sensors applications allows you to specify "PowerState"
parameter for its sensors in the configarition. With this parameter
sensor is sampled/checked against its thresholds only if certain
system conditions are met.
Therefore if sensor becomes unavailable because of the "PowerState"
parameter, all its threshold states must be deasserted.

Tested: tested on the AMD DaytonaX CRB. It is a 2-socket board. For
the test only 1 CPU was installed. In this case voltage sensors that
measure voltages for CPU2 and configured with '"PowerState": "On"'
assert their thresholds when the system is powered on.
Before the patch even if the system is powered off after that, these
voltage sensors stay with the asserted thresholds. Because of that
webui will continue to displays these sensors with a 'Critical' status.
After the patch if system is powered off, the voltage sensors deasset
all their thresholds and the sensors correctly change their status to
'OK' in webui.

Change-Id: Id6a33f15c18ca7aa30e8c449ab9c9e239673dd1f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
1 file changed
tree: c0311e4c425717a9bdbf27241d68879392e43bce
  1. include/
  2. service_files/
  3. src/
  4. subprojects/
  5. tests/
  6. .clang-format
  7. .clang-tidy
  8. .gitignore
  9. LICENSE
  10. meson.build
  11. meson_options.txt
  12. OWNERS
  13. README.md
README.md

dbus-sensors

dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.

key features

  • runtime re-configurable from d-bus (entity-manager or the like)

  • isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible

  • async single-threaded: uses sdbusplus/asio bindings

  • multiple data inputs: hwmon, d-bus, direct driver access

dbus interfaces

A typical dbus-sensors object support the following dbus interfaces:

Path        /xyz/openbmc_project/sensors/<type>/<sensor_name>

Interfaces  xyz.openbmc_project.Sensor.Value
            xyz.openbmc_project.Sensor.Threshold.Critical
            xyz.openbmc_project.Sensor.Threshold.Warning
            xyz.openbmc_project.State.Decorator.Availability
            xyz.openbmc_project.State.Decorator.OperationalStatus
            xyz.openbmc_project.Association.Definitions

Sensor interfaces collection are described here.

Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.

Reactor

dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.

Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.

A simple sensor example can be found here.

configuration

Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.

sensor documentation