commit e73bd0a11e54b7d2a7037d0b1e8d49de1042f44a
author Andrew Jeffery <andrew@aj.id.au> Wed Jan 25 10:39:57 2023 +1030
committer Andrew Jeffery <andrew@aj.id.au> Wed Jan 25 10:45:23 2023 +1030
tree c2345d4da32f08c3f1bd9ea402de30bf4bb2bcbf
parent ea148ec6f913c1b1d4a145591097628b01384d96

sensors: Align source structure away from anti-patterns

The anti-patterns document comments on source structure, specifically
on placing internal headers in a parallel subtree[1]. dbus-sensors is an
example of violating this anti-pattern, so fix it.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#placing-internal-headers-in-a-parallel-subtree

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I50ecaddd53fa9c9b7a0441af9de5e60bd94e47c6

tests/meson.build

diff --git a/tests/meson.build b/tests/meson.build
index 51d5d60..008ba19 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -34,7 +34,7 @@
         'test_HwmonTempSensor.cpp',
         dependencies: ut_deps_list,
         implicit_include_directories: false,
-        include_directories: '../include',
+        include_directories: '../src',
     )
 )
 
@@ -45,7 +45,7 @@
         'test_TachSensor.cpp',
         dependencies: ut_deps_list,
         implicit_include_directories: false,
-        include_directories: '../include',
+        include_directories: '../src',
     )
 )
 endif
@@ -58,6 +58,6 @@
         '../src/Utils.cpp',
         dependencies: ut_deps_list,
         implicit_include_directories: false,
-        include_directories: '../include',
+        include_directories: '../src',
     )
 )

tests/test_HwmonTempSensor.cpp

diff --git a/tests/test_HwmonTempSensor.cpp b/tests/test_HwmonTempSensor.cpp
index dc354a8..6ae65ce 100644
--- a/tests/test_HwmonTempSensor.cpp
+++ b/tests/test_HwmonTempSensor.cpp
@@ -1,5 +1,6 @@
-#include <HwmonTempSensor.hpp>
-#include <dbus/connection.hpp>
+#include "HwmonTempSensor.hpp"
+#include "dbus/connection.hpp"
+
 #include <nlohmann/json.hpp>
 
 #include <fstream>

tests/test_TachSensor.cpp

diff --git a/tests/test_TachSensor.cpp b/tests/test_TachSensor.cpp
index 6ecb79d..01397d3 100644
--- a/tests/test_TachSensor.cpp
+++ b/tests/test_TachSensor.cpp
@@ -1,5 +1,6 @@
-#include <TachSensor.hpp>
-#include <Thresholds.hpp>
+#include "TachSensor.hpp"
+#include "Thresholds.hpp"
+
 #include <dbus/connection.hpp>
 #include <nlohmann/json.hpp>
 

tests/test_Utils.cpp

diff --git a/tests/test_Utils.cpp b/tests/test_Utils.cpp
index e12bc16..2be1027 100644
--- a/tests/test_Utils.cpp
+++ b/tests/test_Utils.cpp
@@ -1,4 +1,4 @@
-#include <Utils.hpp>
+#include "Utils.hpp"
 
 #include <array>
 #include <filesystem>