commit ebd2a38d4275485ebab90d74cfac658b3c60aa20
author Patrick Williams <patrick@stwcx.xyz> Wed May 14 08:48:58 2025 -0400
committer Andrew Jeffery <andrew@codeconstruct.com.au> Thu May 15 00:27:48 2025 +0000
tree ea39ce388c7d5dae8b559887556b467a6783af09
parent 80c68051de173c7bbde2dafa127ff612d8e5bb04

ipmbsensor: fix clang-tidy warning

clang-tidy-20 is much more aggressive about accessing std::optional
values, even though we have plenty of fencing in this case.  Use
`value_or` to squash the clang-tidy warning.

```
../src/ipmb/IpmbSensor.cpp:165:53: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
  165 |         "sendRequest", commandAddress, netfn, lun, *initCommand, initData);
      |                                                     ^
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice3ac15dc74c3193d24a03d627555244ffc0dadb

src/ipmb/IpmbSensor.cpp

diff --git a/src/ipmb/IpmbSensor.cpp b/src/ipmb/IpmbSensor.cpp
index 658c875..a1f5db2 100644
--- a/src/ipmb/IpmbSensor.cpp
+++ b/src/ipmb/IpmbSensor.cpp
@@ -125,10 +125,7 @@
 {
     loadDefaults();
     setInitialProperties(getSubTypeUnits());
-    if (initCommand)
-    {
-        runInitCmd();
-    }
+    runInitCmd();
     read();
 }
 
@@ -151,7 +148,7 @@
 
 void IpmbSensor::runInitCmd()
 {
-    if (!initCommand)
+    if (!initCommand.has_value())
     {
         return;
     }
@@ -162,7 +159,8 @@
         },
         "xyz.openbmc_project.Ipmi.Channel.Ipmb",
         "/xyz/openbmc_project/Ipmi/Channel/Ipmb", "org.openbmc.Ipmb",
-        "sendRequest", commandAddress, netfn, lun, *initCommand, initData);
+        "sendRequest", commandAddress, netfn, lun, initCommand.value_or(0),
+        initData);
 }
 
 void IpmbSensor::loadDefaults()