commit ece5c86a1260185f5fffd469ea8e994f8b39655c
author Zev Weiss <zev@bewilderbeest.net> Fri Aug 05 14:34:59 2022 -0700
committer Zev Weiss <zev@bewilderbeest.net> Tue Nov 08 23:08:11 2022 -0800
tree 472607f95a43c01aaf7bddb0d28efeb6556eacfd
parent 6db8aae453cbffa33e8fe1b8ad0082629cab5f34

Define Sensor::readingStateGood() in terms of readingStateGood()

We can reuse the same logic instead of duplicating it between the
generic global function and the Sensor class method.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ibc77c2fe538398a013aab2b13964e37bb6f17f9e

include/sensor.hpp

diff --git a/include/sensor.hpp b/include/sensor.hpp
index 4578935..f278212 100644
--- a/include/sensor.hpp
+++ b/include/sensor.hpp
@@ -423,20 +423,7 @@
 
     bool readingStateGood() const
     {
-        if (readState == PowerState::on && !isPowerOn())
-        {
-            return false;
-        }
-        if (readState == PowerState::biosPost &&
-            (!hasBiosPost() || !isPowerOn()))
-        {
-            return false;
-        }
-        if (readState == PowerState::chassisOn && !isChassisOn())
-        {
-            return false;
-        }
-        return true;
+        return ::readingStateGood(readState);
     }
 
     void markFunctional(bool isFunctional)