commit ee16434ac66a51479cacb6ad5e7c1b043a85b42e
author Andrew Jeffery <andrew@aj.id.au> Thu Dec 02 16:02:19 2021 +1030
committer Andrew Jeffery <andrew@aj.id.au> Tue Dec 07 04:06:13 2021 +0000
tree 2ad1aa6feb0212c6ffd4686b82c05a625ffa048e
parent 5f070ff7b771e4c0f0260d8f14c1b5d518019fbe

NVMeSensorMain: Drop use of baseConfiguration pointer

Hopefully sensorBase can't be nullptr?

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I256e5c484a94ba42da4ff73e1621784fdbc14759

src/NVMeSensorMain.cpp

diff --git a/src/NVMeSensorMain.cpp b/src/NVMeSensorMain.cpp
index 4f815ae..4c0473e 100644
--- a/src/NVMeSensorMain.cpp
+++ b/src/NVMeSensorMain.cpp
@@ -132,52 +132,40 @@
     nvmeDeviceMap.clear();
 
     // iterate through all found configurations
-    for (const std::pair<sdbusplus::message::object_path, SensorData>& sensor :
-         sensorConfigurations)
+    for (const auto& [interfacePath, sensorData] : sensorConfigurations)
     {
-        const SensorData& sensorData = sensor.second;
-        const std::string& interfacePath = sensor.first.str;
-        const std::pair<std::string, boost::container::flat_map<
-                                         std::string, BasicVariantType>>*
-            baseConfiguration = nullptr;
-
         // find base configuration
-        auto sensorBase = sensor.second.find(sensorType);
-        if (sensorBase != sensor.second.end())
+        auto sensorBase = sensorData.find(sensorType);
+        if (sensorBase != sensorData.end())
         {
-            baseConfiguration = &(*sensorBase);
+            const SensorBaseConfigMap& sensorConfig = sensorBase->second;
+            std::optional<int> busNumber =
+                extractBusNumber(interfacePath, sensorConfig);
+            std::optional<std::string> sensorName =
+                extractSensorName(interfacePath, sensorConfig);
+            std::optional<int> rootBus = deriveRootBus(busNumber);
+
+            if (!(busNumber && sensorName && rootBus))
+            {
+                continue;
+            }
+
+            std::vector<thresholds::Threshold> sensorThresholds;
+            if (!parseThresholdsFromConfig(sensorData, sensorThresholds))
+            {
+                std::cerr << "error populating thresholds for " << *sensorName
+                          << "\n";
+            }
+
+            std::shared_ptr<NVMeSensor> sensorPtr =
+                std::make_shared<NVMeSensor>(
+                    objectServer, io, dbusConnection, *sensorName,
+                    std::move(sensorThresholds), interfacePath, *busNumber);
+
+            std::shared_ptr<NVMeContext> context =
+                provideRootBusContext(io, nvmeDeviceMap, *rootBus);
+            context->addSensor(sensorPtr);
         }
-
-        if (baseConfiguration == nullptr)
-        {
-            continue;
-        }
-
-        std::optional<int> busNumber =
-            extractBusNumber(sensor.first, baseConfiguration->second);
-        std::optional<std::string> sensorName =
-            extractSensorName(sensor.first, baseConfiguration->second);
-        std::optional<int> rootBus = deriveRootBus(busNumber);
-
-        if (!(busNumber && sensorName && rootBus))
-        {
-            continue;
-        }
-
-        std::vector<thresholds::Threshold> sensorThresholds;
-        if (!parseThresholdsFromConfig(sensorData, sensorThresholds))
-        {
-            std::cerr << "error populating thresholds for " << *sensorName
-                      << "\n";
-        }
-
-        std::shared_ptr<NVMeSensor> sensorPtr = std::make_shared<NVMeSensor>(
-            objectServer, io, dbusConnection, *sensorName,
-            std::move(sensorThresholds), interfacePath, *busNumber);
-
-        std::shared_ptr<NVMeContext> context =
-            provideRootBusContext(io, nvmeDeviceMap, *rootBus);
-        context->addSensor(sensorPtr);
     }
     for (const auto& [_, context] : nvmeDeviceMap)
     {