commit ef9665a8afe704f57fb1db2d052f0b6ba9b73622
author Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Thu Oct 10 10:26:39 2019 -0700
committer Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Thu Oct 10 10:43:26 2019 -0700
tree 64b40334b5c896de0bb2e6d446d6fcea0226f825
parent 61bc6dccfeaaf1fbfdddc01bbc754898c7f170da

Fix file descriptor checking

'0' is also a valid file descriptor so this commit fixes incorrect
checks on fd after opening a file. Actually, fd 0, 1 and 2 will be
assigned to stdin, stdout and stderr respectively so this patch
doesn't fix any issue but it's for code consistency.

Tested: Detecting and reading sensors worked well.

Change-Id: I2626a0b92352257d1c294a61ca385f95568dae7d
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

src/ADCSensor.cpp

diff --git a/src/ADCSensor.cpp b/src/ADCSensor.cpp
index 4aa8cc1..330de52 100644
--- a/src/ADCSensor.cpp
+++ b/src/ADCSensor.cpp
@@ -176,7 +176,7 @@
         (*bridgeGpio).set(0);
     }
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return; // we're no longer valid
     }

src/CPUSensor.cpp

diff --git a/src/CPUSensor.cpp b/src/CPUSensor.cpp
index 1b04299..0ec4bf5 100644
--- a/src/CPUSensor.cpp
+++ b/src/CPUSensor.cpp
@@ -204,7 +204,7 @@
     responseStream.clear();
     inputDev.close();
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return; // we're no longer valid
     }

src/HwmonTempSensor.cpp

diff --git a/src/HwmonTempSensor.cpp b/src/HwmonTempSensor.cpp
index 52ad8fe..d4ed57f 100644
--- a/src/HwmonTempSensor.cpp
+++ b/src/HwmonTempSensor.cpp
@@ -133,7 +133,7 @@
     responseStream.clear();
     inputDev.close();
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return; // we're no longer valid
     }

src/PSUEvent.cpp

diff --git a/src/PSUEvent.cpp b/src/PSUEvent.cpp
index 6d2a3e6..cc7374c 100644
--- a/src/PSUEvent.cpp
+++ b/src/PSUEvent.cpp
@@ -175,7 +175,7 @@
     responseStream.clear();
     inputDev.close();
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return;
     }

src/PSUSensor.cpp

diff --git a/src/PSUSensor.cpp b/src/PSUSensor.cpp
index a7156a7..7c9e109 100644
--- a/src/PSUSensor.cpp
+++ b/src/PSUSensor.cpp
@@ -128,7 +128,7 @@
     responseStream.clear();
     inputDev.close();
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return;
     }

src/TachSensor.cpp

diff --git a/src/TachSensor.cpp b/src/TachSensor.cpp
index e000780..cca2f23 100644
--- a/src/TachSensor.cpp
+++ b/src/TachSensor.cpp
@@ -179,7 +179,7 @@
     responseStream.clear();
     inputDev.close();
     int fd = open(path.c_str(), O_RDONLY);
-    if (fd <= 0)
+    if (fd < 0)
     {
         return; // we're no longer valid
     }