commit f69fbf998745bf006748c3b6ba6558443b560d21
author Ed Tanous <edtanous@google.com> Fri Jan 14 10:15:33 2022 -0800
committer Ed Tanous <ed@tanous.net> Tue Jan 25 19:27:34 2022 +0000
tree a1fe591ee9f1cd5ecf5c93490a53a93742470f88
parent 62fd8073d11ca26695f0c90d1a93e11c7059f079

Consistently use std::pair<double, double> limits

There are a number of places in tach sensor where we jump from having a
pair of doubles, so having a pair of ints, then back.  All sensors take
this as a double, so we should be consistent, even if tachsensor is only
expected to have integer units.

This was flagged by clang-tidy as part of the
bugprone-misplaced-widening-cast check.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iee1439f3af2bf8c15dc33f91c63859c5d1b776ca

include/TachSensor.hpp

diff --git a/include/TachSensor.hpp b/include/TachSensor.hpp
index 8dd1b88..75dcd06 100644
--- a/include/TachSensor.hpp
+++ b/include/TachSensor.hpp
@@ -69,7 +69,7 @@
                boost::asio::io_service& io, const std::string& fanName,
                std::vector<thresholds::Threshold>&& thresholds,
                const std::string& sensorConfiguration,
-               const std::pair<size_t, size_t>& limits,
+               const std::pair<double, double>& limits,
                const PowerState& powerState,
                const std::optional<std::string>& led);
     ~TachSensor() override;

src/FanMain.cpp

diff --git a/src/FanMain.cpp b/src/FanMain.cpp
index a32d054..112848b 100644
--- a/src/FanMain.cpp
+++ b/src/FanMain.cpp
@@ -369,7 +369,7 @@
 
                 constexpr double defaultMaxReading = 25000;
                 constexpr double defaultMinReading = 0;
-                auto limits =
+                std::pair<double, double> limits =
                     std::make_pair(defaultMinReading, defaultMaxReading);
 
                 auto connector =

src/TachSensor.cpp

diff --git a/src/TachSensor.cpp b/src/TachSensor.cpp
index 4ba7777..09194f2 100644
--- a/src/TachSensor.cpp
+++ b/src/TachSensor.cpp
@@ -46,7 +46,7 @@
                        boost::asio::io_service& io, const std::string& fanName,
                        std::vector<thresholds::Threshold>&& thresholdsIn,
                        const std::string& sensorConfiguration,
-                       const std::pair<size_t, size_t>& limits,
+                       const std::pair<double, double>& limits,
                        const PowerState& powerState,
                        const std::optional<std::string>& ledIn) :
     Sensor(escapeName(fanName), std::move(thresholdsIn), sensorConfiguration,