commit 116d25a99d4dd87115989086427247ab490335d9
author Jagpal Singh Gill <paligill@gmail.com> Mon Jul 08 14:57:30 2024 -0700
committer Jagpal Singh Gill <paligill@gmail.com> Wed Jul 10 09:53:08 2024 -0700
tree 4135d1a8bf9d5a53b3860310db441b6bf00abf22
parent f73cb6968165f747b19a6a816abe46d309d30346

code-update: fix flow to asynchronous image verify

Update the flow to asynchronously verify the image since this can take
sometime and block the task creation. Also, update the activation status
at appropriate places to notify status changes.

Change-Id: Iddf997a18a94a3d8ee2d61f8f04f40cfe19b3342
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

designs/code-update.md

diff --git a/designs/code-update.md b/designs/code-update.md
index 96de1f5..2321fce 100644
--- a/designs/code-update.md
+++ b/designs/code-update.md
@@ -75,14 +75,9 @@
   note over BMCW: Get serviceName corresponding to the object path <br>from mapper.
   BMCW ->> CU: StartUpdate(Image, ApplyTime)
 
-  note over CU: Verify Image
-  break Image Verification FAILED
-      CU -->> BMCW: {NULL, Update.Error}
-      BMCW -->> CL: Return Error
-  end
   note over CU: Swid = <DeviceX>_<RandomId>
   note over CU: ObjectPath = /xyz/openbmc_project/Software/<SwId>
-  CU ->> CU: Create Interface<br> xyz.openbmc_project.Software.Version<br> at ObjectPath
+  CU ->> CU: Create Interface<br>xyz.openbmc_project.Software.Activation<br> at ObjectPath with Status = NotReady
   CU -->> BMCW: {ObjectPath, Success}
   CU ->> CU: << Delegate Update for asynchronous processing >>
 
@@ -97,9 +92,19 @@
           BMCW -->>CL: TaskStatus
       end
   and << Asynchronous Update in Progress >>
-      CU ->> CU: Create Interface<br>xyz.openbmc_project.Software.Activation<br> at ObjectPath with Status = Ready
+      note over CU: Verify Image
+      break Image Verification FAILED
+        CU ->> CU: Activation.Status = Invalid
+        CU --) BMCW: Notify Activation.Status change
+      end
+      CU ->> CU: Activation.Status = Ready
+      CU --) BMCW: Notify Activation.Status change
+
+      CU ->> CU: Create Interface<br> xyz.openbmc_project.Software.Version<br> at ObjectPath
       CU ->> CU: Create Interface<br>xyz.openbmc_project.Software.ActivationProgress<br> at ObjectPath
       CU ->> CU: Create Interface<br> xyz.openbmc_project.Software.ActivationBlocksTransition<br> at ObjectPath
+      CU ->> CU: Activation.Status = Activating
+      CU --) BMCW: Notify Activation.Status change
       note over CU: Start Update
       loop
           CU --) BMCW: Notify ActivationProgress.Progress change