Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / docs / 90629cc4fe5004c98d085d639db521c45f169c7b
commit90629cc4fe5004c98d085d639db521c45f169c7b[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Thu Feb 06 06:04:33 2025 +0000
committerLei YU <yulei.sh@bytedance.com>Thu Feb 06 06:13:19 2025 +0000
treef351717d6a8b6fe775e2e97e0724f99a4dd44b3b
parent57a48b218f234412662c72141323c1552478e75c [diff]
clang-tidy: Add bugprone-unchecked-optional-access

Starting from meson 1.4.0[1], `-D_GLIBCXX_ASSERTIONS=1` is set if
`ndebug` is disabled.

This unveals a bug in the OpenBMC code, that it uses the std::optional
value without checking if it's empty.
It is undefined behavior, and without `-D_GLIBCXX_ASSERTIONS=1`, the
code runs OK to access the "default" value; And it gets assertion and
crash if `-D_GLIBCXX_ASSERTIONS=1` is set.

It is possible to use clang-tidy's `bugprone-unchecked-optional-access`
option to detect such issue in the build time.

[1]: https://mesonbuild.com/Release-notes-for-1-4-0.html#ndebug-setting-now-controls-c-stdlib-assertions

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I32f64b02b9593a6af6c26af66c386689717336dd
1 file changed
tree: f351717d6a8b6fe775e2e97e0724f99a4dd44b3b
  1. architecture/
  2. designs/
  3. development/
  4. logo/
  5. process/
  6. release/
  7. security/
  8. style/
  9. testing/
  10. tof/
  11. userguide/
  12. .markdownlint.yaml
  13. .prettierrc.yaml
  14. anti-patterns.md
  15. cheatsheet.md
  16. code-of-conduct.md
  17. community-membership.md
  18. console.md
  19. CONTRIBUTING.md
  20. cpp-style-and-conventions.md
  21. discord-rules.md
  22. features.md
  23. glossary.md
  24. host-management.md
  25. hw-vendor-repos-policy.md
  26. IPMITOOL-cheatsheet.md
  27. kernel-development.md
  28. LICENSE
  29. maintainer-workflow.md
  30. Makefile
  31. meta-layer-guidelines.md
  32. openbmc-conversion.md
  33. OWNERS
  34. README.md
  35. REDFISH-cheatsheet.md
  36. rest-api.md
  37. REST-cheatsheet.md
  38. SECURITY.md
  39. subtree.md
  40. yocto-development.md
README.md

OpenBMC documentation

The OpenBMC project is a Linux Foundation project whose goal is to produce a customizable, open-source firmware stack for Baseboard Management Controllers (BMCs). This repository contains documentation for OpenBMC as a whole. There may be component-specific documentation in the repository for each component.

The features document lists the project's major features with links to more information.

Contact

OpenBMC Development

These documents contain details on developing OpenBMC code itself

OpenBMC Usage

These documents describe how to use OpenBMC, including using the programmatic interfaces to an OpenBMC system.