clang-tidy: Add bugprone-unchecked-optional-access
Starting from meson 1.4.0[1], `-D_GLIBCXX_ASSERTIONS=1` is set if
`ndebug` is disabled.
This unveals a bug in the OpenBMC code, that it uses the std::optional
value without checking if it's empty.
It is undefined behavior, and without `-D_GLIBCXX_ASSERTIONS=1`, the
code runs OK to access the "default" value; And it gets assertion and
crash if `-D_GLIBCXX_ASSERTIONS=1` is set.
It is possible to use clang-tidy's `bugprone-unchecked-optional-access`
option to detect such issue in the build time.
[1]: https://mesonbuild.com/Release-notes-for-1-4-0.html#ndebug-setting-now-controls-c-stdlib-assertions
Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I32f64b02b9593a6af6c26af66c386689717336dd
diff --git a/style/cpp/.clang-tidy b/style/cpp/.clang-tidy
index 16fff78..c566465 100644
--- a/style/cpp/.clang-tidy
+++ b/style/cpp/.clang-tidy
@@ -1,5 +1,6 @@
Checks: '
-*,
+ bugprone-unchecked-optional-access,
readability-function-size,
readability-function-cognitive-complexity
'