tree bdea2984228e5307a7b9133be441568a1be420fc
parent 13f3ef1165679115248a79759fa2ba295ceafaf2
author Patrick Venture <venture@google.com> 1565973211 -0700
committer Patrick Venture <venture@google.com> 1565975677 -0700

frudevice: increment value for duplicate dbus paths

In the event of duplicate dbus paths the code would previously count the
instances and append that value to the new dbus path:

busctl tree --no-pager xyz.openbmc_project.FruDevice
`-/xyz
  `-/xyz/openbmc_project
    `-/xyz/openbmc_project/FruDevice
      |-/xyz/openbmc_project/FruDevice/Proving
      |-/xyz/openbmc_project/FruDevice/Altruism
      |-/xyz/openbmc_project/FruDevice/SuperDuper
      |-/xyz/openbmc_project/FruDevice/SuperDuper_0
      |-/xyz/openbmc_project/FruDevice/SuperDuper_01
      |-/xyz/openbmc_project/FruDevice/Power_Now
      |-/xyz/openbmc_project/FruDevice/Granite_HalfDome
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_0
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_01
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_012
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_0123
      `-/xyz/openbmc_project/FruDevice/Fun_Times

Now, the code detects if there is a matching name that optionally has a
value added to the end and then will find the highest number (if any
found) and increment that.

busctl tree --no-pager xyz.openbmc_project.FruDevice
`-/xyz
  `-/xyz/openbmc_project
    `-/xyz/openbmc_project/FruDevice
      |-/xyz/openbmc_project/FruDevice/Proving
      |-/xyz/openbmc_project/FruDevice/Altruism
      |-/xyz/openbmc_project/FruDevice/SuperDuper
      |-/xyz/openbmc_project/FruDevice/SuperDuper_0
      |-/xyz/openbmc_project/FruDevice/SuperDuper_1
      |-/xyz/openbmc_project/FruDevice/Power_Now
      |-/xyz/openbmc_project/FruDevice/Granite_HalfDome
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_0
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_1
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_2
      |-/xyz/openbmc_project/FruDevice/Super_Great_V200_3
      `-/xyz/openbmc_project/FruDevice/Fun_Times

In the event that a product name is something like "Yes And 2" =>
"Yes_And_2" for the productName variable.  The second one you find will
be "Yes_And_2_0" because the productName is treated as the base
for the regex searches.

Tested: Ran on my platform above with sanitized values.  Also wrote a
small program to exercise edge cases.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I106ff2fe278939185cf4b3215784f85bb87523b0