ProductId: remove property
At both the top-level and in Item.Board.Motherboard schemas was a
required property: "ProductId". This property has never been documented
in phosphor-dbus-interfaces and is only used in exactly 1 OEM IPMI
provider (and no where else)[1, 2]. Strip this unused property out.
Test Plan: entity-manager schema validators pass. Search in code base
for usages.
[1]: https://github.com/openbmc/intel-ipmi-oem/blob/0fcc73f1cf8c486bb8079e68813c239c4cc41bbc/src/oemcommands.cpp#L2929
[2]: https://github.com/search?q=org%3Aopenbmc+%2F%28%3F-i%29ProductId%2F+-repo%3Aopenbmc%2Flinux+-repo%3Aopenbmc%2Fqemu&type=code
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I81f02c54aaee78e5d1c3b3e020437ebd3d7b4e3f
diff --git a/configurations/meta/harma_mb.json b/configurations/meta/harma_mb.json
index 931d9f8..c5e700e 100644
--- a/configurations/meta/harma_mb.json
+++ b/configurations/meta/harma_mb.json
@@ -1223,9 +1223,7 @@
"xyz.openbmc_project.Inventory.Decorator.AssetTag": {
"AssetTag": "$PRODUCT_ASSET_TAG"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
},
{
"Exposes": [
diff --git a/configurations/meta/harma_mb_vr_infineon.json b/configurations/meta/harma_mb_vr_infineon.json
index 7ca9e5d..f6137c8 100644
--- a/configurations/meta/harma_mb_vr_infineon.json
+++ b/configurations/meta/harma_mb_vr_infineon.json
@@ -1221,9 +1221,7 @@
"xyz.openbmc_project.Inventory.Decorator.AssetTag": {
"AssetTag": "$PRODUCT_ASSET_TAG"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
},
{
"Exposes": [
diff --git a/configurations/meta/minerva_cmm.json b/configurations/meta/minerva_cmm.json
index 21cadb8..822774f 100644
--- a/configurations/meta/minerva_cmm.json
+++ b/configurations/meta/minerva_cmm.json
@@ -260,9 +260,7 @@
"xyz.openbmc_project.Inventory.Decorator.AssetTag": {
"AssetTag": "$PRODUCT_ASSET_TAG"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- },
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {},
"xyz.openbmc_project.Inventory.Item.NetworkInterface": {
"MACAddress": "$CHASSIS_INFO_AM2"
}
diff --git a/configurations/meta/minerva_cmm_hsc_infineon.json b/configurations/meta/minerva_cmm_hsc_infineon.json
index 580ac63..e3e7480 100644
--- a/configurations/meta/minerva_cmm_hsc_infineon.json
+++ b/configurations/meta/minerva_cmm_hsc_infineon.json
@@ -286,9 +286,7 @@
"xyz.openbmc_project.Inventory.Decorator.AssetTag": {
"AssetTag": "$PRODUCT_ASSET_TAG"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- },
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {},
"xyz.openbmc_project.Inventory.Item.NetworkInterface": {
"MACAddress": "$CHASSIS_INFO_AM2"
}
diff --git a/configurations/meta/ventura_rmc_hsc_ltc_fsc_max_p24vsen_ina_gndsen_ina_p12vbrick_delta.json b/configurations/meta/ventura_rmc_hsc_ltc_fsc_max_p24vsen_ina_gndsen_ina_p12vbrick_delta.json
index a8f6f2e..2d24e83 100644
--- a/configurations/meta/ventura_rmc_hsc_ltc_fsc_max_p24vsen_ina_gndsen_ina_p12vbrick_delta.json
+++ b/configurations/meta/ventura_rmc_hsc_ltc_fsc_max_p24vsen_ina_gndsen_ina_p12vbrick_delta.json
@@ -287,9 +287,7 @@
"xyz.openbmc_project.Inventory.Decorator.Revision": {
"Version": "$PRODUCT_VERSION"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- },
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {},
"xyz.openbmc_project.Inventory.Item.NetworkInterface": {
"MACAddress": "$CHASSIS_INFO_AM2"
}
diff --git a/configurations/meta/ventura_rmc_hsc_xdp_fsc_nct_p24vsen_isl_gndsen_isl_p12vbrick_flex.json b/configurations/meta/ventura_rmc_hsc_xdp_fsc_nct_p24vsen_isl_gndsen_isl_p12vbrick_flex.json
index 024c68e..4eda3f4 100644
--- a/configurations/meta/ventura_rmc_hsc_xdp_fsc_nct_p24vsen_isl_gndsen_isl_p12vbrick_flex.json
+++ b/configurations/meta/ventura_rmc_hsc_xdp_fsc_nct_p24vsen_isl_gndsen_isl_p12vbrick_flex.json
@@ -283,9 +283,7 @@
"xyz.openbmc_project.Inventory.Decorator.Revision": {
"Version": "$PRODUCT_VERSION"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- },
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {},
"xyz.openbmc_project.Inventory.Item.NetworkInterface": {
"MACAddress": "$CHASSIS_INFO_AM2"
}
diff --git a/configurations/meta/yosemite4_sentineldome_t1.json b/configurations/meta/yosemite4_sentineldome_t1.json
index 949a539..67364e2 100644
--- a/configurations/meta/yosemite4_sentineldome_t1.json
+++ b/configurations/meta/yosemite4_sentineldome_t1.json
@@ -383,7 +383,5 @@
"xyz.openbmc_project.Inventory.Decorator.Slot": {
"SlotNumber": "$bus % 15"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
}
diff --git a/configurations/meta/yosemite4_sentineldome_t1_retimer.json b/configurations/meta/yosemite4_sentineldome_t1_retimer.json
index aaef830..a542ad2 100644
--- a/configurations/meta/yosemite4_sentineldome_t1_retimer.json
+++ b/configurations/meta/yosemite4_sentineldome_t1_retimer.json
@@ -443,7 +443,5 @@
"xyz.openbmc_project.Inventory.Decorator.Slot": {
"SlotNumber": "$bus % 15"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
}
diff --git a/configurations/meta/yosemite4_sentineldome_t2.json b/configurations/meta/yosemite4_sentineldome_t2.json
index c88c453..6790468 100644
--- a/configurations/meta/yosemite4_sentineldome_t2.json
+++ b/configurations/meta/yosemite4_sentineldome_t2.json
@@ -454,7 +454,5 @@
"xyz.openbmc_project.Inventory.Decorator.Slot": {
"SlotNumber": "$bus % 15"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
}
diff --git a/configurations/meta/yosemite4_sentineldome_t2_retimer.json b/configurations/meta/yosemite4_sentineldome_t2_retimer.json
index ee41d00..2593ade 100644
--- a/configurations/meta/yosemite4_sentineldome_t2_retimer.json
+++ b/configurations/meta/yosemite4_sentineldome_t2_retimer.json
@@ -514,7 +514,5 @@
"xyz.openbmc_project.Inventory.Decorator.Slot": {
"SlotNumber": "$bus % 15"
},
- "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {
- "ProductId": 1
- }
+ "xyz.openbmc_project.Inventory.Item.Board.Motherboard": {}
}