| commit | 6eb609721d8297c94d587b1ee471cd0aa66669a2 | [log] [tgz] |
|---|---|---|
| author | Matt Spinler <spinler@us.ibm.com> | Mon Aug 14 16:36:20 2023 -0500 |
| committer | Zhikui Ren <zhikui.ren@intel.com> | Fri Aug 25 15:31:31 2023 +0000 |
| tree | 525c46b26e1cff883fcbf56a093b34dd7159b942 | |
| parent | 3d1909ae29595845ed0f5eab93453588246821a0 [diff] |
phys-topology: Add late add/remove support The current physical topology code doesn't yet support adding entities late (in a different propertiesChangedCallback call) or removing an entity because: - The Topology class is just scoped to postToDbus(), so when that is called again later with new cards it has no concept of existing parent cards so it will miss creating associations. - There is nothing to tell the class when an entity is removed, so it never attempts to remove the association for that entity. - When the containing/contained_by association is created it doesn't use the createInterface() function, so if that entity is removed later that association interface will be left on D-Bus. To add support for entity adds and removes, this commit will: - Make the Topology class have a global scoped lifetime so it can remember entity relationships. - Now that Topology will outlive postToDbus() calls, pass the getAssocs() method the list of boards being processed in the current postToDbus() incantation so it will only return the new associations. - Use the createInterface() method when creating the association. This stores the interface in a map with the entity name so that when the entity is removed the interface will be removed along with all the other interfaces. - When an entity is removed, only the board name is known. So pass the board name into addBoard() so the Topology class knows it, and add a Topology::remove() method and call it so it can remove the removed path from all of the connector maps. Tested: - All of the containing/contained_by associations still show up on good path. - Added new unit tests to cover the new functionality. - When a downstream entity is added after EM does its initial D-Bus publish, the containing/contained_by association is now created. - On an entity remove, there are no left over interfaces for the removed entity on D-Bus. - When the removed entity is added back, the association is put back in place. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ie5daaca92c6d2e6e7abc408f3e67e948977581ef
Entity manager is a design for managing physical system components, and mapping them to software resources within the BMC. Said resources are designed to allow the flexible adjustment of the system at runtime, as well as the reduction in the number of independent system configurations one needs to create.
A server component that is physically separate, detectable through some means, and can be added or removed from a given OpenBMC system. Said component can, and likely does contain multiple sub-components, but the component itself as a whole is referred to as an entity.
Note, this term is needed because most other terms that could've been used (Component, Field Replaceable Unit, or Assembly) are already overloaded in the industry, and have a distinct definition already, which is a subset of what an entity encompasses.
A particular feature of an Entity. An Entity generally will have multiple Exposes records for the various features that component supports. Some examples of features include, LM75 sensors, PID control parameters, or CPU information.
A set of rules for detecting a given entity. Said rules generally take the form of a D-Bus interface definition.
Entity manager has the following goals (unless you can think of better ones):
A full BMC setup using Entity Manager consists of a few parts:
A detection daemon This is something that can be used to detect components at runtime. The most common of these, fru-device, is included in the Entity-Manager repo, and scans all available I2C buses for IPMI FRU EEPROM devices. Other examples of detection daemons include: peci-pcie: A daemon that utilizes the CPU bus to read in a list of PCIe devices from the processor. smbios-mdr: A daemon that utilizes the x86 SMBIOS table specification to detect the available systems dependencies from BIOS.
In many cases, the existing detection daemons are sufficient for a single system, but in cases where there is a superseding inventory control system in place (such as in a large datacenter) they can be replaced with application specific daemons that speak the protocol information of their controller, and expose the inventory information, such that failing devices can be detected more readily, and system configurations can be "verified" rather than detected.
An entity manager configuration file Entity manager configuration files are located in the ./configurations directory in the entity manager repository, and include one file per device supported. Entities are detected based on the "Probe" key in the json file. The intention is that this folder contains all hardware configurations that OpenBMC supports, to allows an easy answer to "Is X device supported". An EM configuration contains a number of Exposes records that specify the specific features that this Entity supports. Once a component is detected, entity manager will publish these Exposes records to D-Bus.
A reactor The reactors are things that take the entity manager configurations, and use them to execute and enable the features that they describe. One example of this is dbus-sensors, which contains a suite of applications that input the Exposes records for sensor devices, then connect to the filesystem to create the sensors and scan loops to scan sensors for those devices. Other examples of reactors could include: CPU management daemons and Hot swap backplane management daemons, or drive daemons.
note: In some cases, a given daemon could be both a detection daemon and a reactor when architectures are multi-tiered. An example of this might include a hot swap backplane daemon, which both reacts to the hot swap being detected, and also creates detection records of what drives are present.
Entity manager shall support the dynamic discovery of hardware at runtime, using inventory interfaces. The types of devices include, but are not limited to hard drives, hot swap backplanes, baseboards, power supplies, CPUs, and PCIe Add-in-cards.
Entity manager shall support the ability to add or remove support for particular devices in a given binary image. By default, entity manager will support all available and known working devices for all platforms.
Entity manager shall provide data to D-Bus about a particular device such that other daemons can create instances of the features being exposed.
Entity manager shall support multiple detection runs, and shall do the minimal number of changes necessary when new components are detected or no longer detected. Some examples of re-detection events might include host power on, drive plug/unplug, PSU plug/unplug.
Entity manager shall have exactly one configuration file per supported device model. In some cases this will cause duplicated information between files, but the ability to list and see all supported device models in a single place, as well as maintenance when devices do differ in the future is determined to be more important than duplication of configuration files.
bmcweb A webserver implementation that uses the inventory information from entity-manager to produce a Redfish compliant REST API. intel-ipmi-oem An implementation of the IPMI SDR, FRU, and Storage commands that utilize Entity Manager as the source of information.