probe: Change FoundProbeTypeT to point to the optional enum
`findProbeType` return is only ever used for the returned
enumeration rather than the iterator. Having it return the
iterator has additional complications since the original
code had the map be a local variable and we were playing
with undefined behavior. Looking further, none of the
callers seem to want the iterator and the return type
is making them perform more work.
Change-Id: I81b73d5b1555abfbe07569bcf0fcdd14b031704d
Signed-off-by: Amithash Prasad <amithash@meta.com>
diff --git a/src/entity_manager/perform_probe.hpp b/src/entity_manager/perform_probe.hpp
index f979c52..4edbe35 100644
--- a/src/entity_manager/perform_probe.hpp
+++ b/src/entity_manager/perform_probe.hpp
@@ -29,8 +29,7 @@
MATCH_ONE
};
-using FoundProbeTypeT = std::optional<boost::container::flat_map<
- const char*, probe_type_codes, CmpStr>::const_iterator>;
+using FoundProbeTypeT = std::optional<probe_type_codes>;
FoundProbeTypeT findProbeType(const std::string& probe);