Remove implicit conversions
Implicit conversions are something that nlohmann library itself is a bad
default, and 3 years ago threatened to change the default. These
implicit conversions cause a number of crashes that are hard to
reproduce, because they throw an uncaught exception.
Update the code to be able to do no more implicit conversions.
Tested: Entity-manager launches and runs. Items are detected correctly
and show up on dbus. Unit tests pass.
Change-Id: Ib23159ae58f5584641427d9be7545bc25a3619af
Signed-off-by: Ed Tanous <etanous@nvidia.com>
diff --git a/src/entity_manager/dbus_interface.cpp b/src/entity_manager/dbus_interface.cpp
index 0610812..36ec10d 100644
--- a/src/entity_manager/dbus_interface.cpp
+++ b/src/entity_manager/dbus_interface.cpp
@@ -144,7 +144,7 @@
static void populateInterfacePropertyFromJson(
nlohmann::json& systemConfiguration, const std::string& path,
- const nlohmann::json& key, const nlohmann::json& value,
+ const std::string& key, const nlohmann::json& value,
nlohmann::json::value_t type,
std::shared_ptr<sdbusplus::asio::dbus_interface>& iface,
sdbusplus::asio::PropertyPermission permission)