commit 77b3c06c97c34ee95e73e3019ee6a1ca24602461
author Andrew Jeffery <andrew@aj.id.au> Thu Apr 07 17:11:39 2022 +0930
committer Andrew Jeffery <andrew@aj.id.au> Wed Apr 13 16:18:29 2022 +0930
tree b51213769b329d190b0c41f856e01b25b034fda6
parent 159588b08734dc31230b421d51733d8e3205b447

Utils: Simplify 'replaced' loop exit in templateCharReplace()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I33dfa9245dedfc8587fe0019fcc37dbe1076f82a

src/Utils.cpp

diff --git a/src/Utils.cpp b/src/Utils.cpp
index 04f8f25..4ebb246 100644
--- a/src/Utils.cpp
+++ b/src/Utils.cpp
@@ -304,14 +304,10 @@
         std::string result = prefix + std::to_string(number);
 
         std::string replaced(find.begin(), find.end());
-        for (auto it2 = split.begin(); it2 != split.end(); it2++)
+        for (auto it2 = split.begin(); it2 != it; it2++)
         {
             replaced += " ";
             replaced += *it2;
-            if (it2 == it)
-            {
-                break;
-            }
         }
         ret = replaced;