Back out multiply by 100 for pid-control
This change
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-pid-control/+/17952/
Backs out the divide by 100 to make the numbers less
confusing in the configuration. This change is the other
half of that to keep the configuration the same.
Tested-by: Tested boosting fans on WFP platform and
idle speeds worked correctly
Change-Id: Ib51fe119f50b66682a1eb49ba05a552fb1e3ea3f
Signed-off-by: James Feist <james.feist@linux.intel.com>
diff --git a/configurations/FBTP.json b/configurations/FBTP.json
index 7d958e9..87754ab 100644
--- a/configurations/FBTP.json
+++ b/configurations/FBTP.json
@@ -374,19 +374,19 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -20.0,
- "ILimitMax": 7000,
- "ILimitMin": 3000,
+ "ICoefficient": -0.2,
+ "ILimitMax": 70,
+ "ILimitMin": 30,
"Inputs": [
"MB_INLET_TEMP"
],
"Name": "MB_INLET_TEMP",
- "OutLimitMax": 7000,
- "OutLimitMin": 3000,
+ "OutLimitMax": 70,
+ "OutLimitMin": 30,
"Outputs": [],
- "PCoefficient": -300.0,
+ "PCoefficient": -3.0,
"SetPoint": 45.0,
- "SlewNeg": -100,
+ "SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
"Zones": [
@@ -397,19 +397,19 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -20.0,
- "ILimitMax": 7000,
- "ILimitMin": 3000,
+ "ICoefficient": -0.2,
+ "ILimitMax": 70,
+ "ILimitMin": 30,
"Inputs": [
"MEZZ_SENSOR_REMOTE_TEMP"
],
"Name": "MEZZ_SENSOR_REMOTE_TEMP",
- "OutLimitMax": 7000,
- "OutLimitMin": 3000,
+ "OutLimitMax": 70,
+ "OutLimitMin": 30,
"Outputs": [],
- "PCoefficient": -300.0,
+ "PCoefficient": -3.0,
"SetPoint": 45.0,
- "SlewNeg": -100,
+ "SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
"Zones": [
@@ -420,19 +420,19 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -20.0,
- "ILimitMax": 7000,
- "ILimitMin": 3000,
+ "ICoefficient": -0.2,
+ "ILimitMax": 70,
+ "ILimitMin": 30,
"Inputs": [
"Core 0 CPU0"
],
"Name": "Core 0 CPU0",
- "OutLimitMax": 7000,
- "OutLimitMin": 3000,
+ "OutLimitMax": 70,
+ "OutLimitMin": 30,
"Outputs": [],
- "PCoefficient": -300.0,
+ "PCoefficient": -3.0,
"SetPoint": 45.0,
- "SlewNeg": -100,
+ "SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
"Zones": [
@@ -477,4 +477,4 @@
"PartNumber": "$PRODUCT_PART_NUMBER",
"SerialNumber": "$PRODUCT_SERIAL_NUMBER"
}
-}
\ No newline at end of file
+}
diff --git a/configurations/R1000 Chassis.json b/configurations/R1000 Chassis.json
index 44a313b..96ededf 100644
--- a/configurations/R1000 Chassis.json
+++ b/configurations/R1000 Chassis.json
@@ -421,8 +421,8 @@
"Name": "Front Panel Temp",
"NegativeHysteresis": 2,
"Output": [
- 3000.0,
- 5000.0
+ 30.0,
+ 50.0
],
"PositiveHysteresis": 0,
"Reading": [
@@ -435,7 +435,7 @@
]
},
{
- "FailSafePercent": 90,
+ "FailSafePercent": 100,
"MinThermalRpm": 3000,
"Name": "Pid 1",
"Type": "Pid.Zone"
@@ -492,4 +492,4 @@
"PartNumber": "R1208",
"SerialNumber": "23165"
}
-}
\ No newline at end of file
+}
diff --git a/configurations/R2000 Chassis.json b/configurations/R2000 Chassis.json
index caccd45..4be6450 100644
--- a/configurations/R2000 Chassis.json
+++ b/configurations/R2000 Chassis.json
@@ -307,8 +307,8 @@
"Name": "Front Panel Temp",
"NegativeHysteresis": 2,
"Output": [
- 3000.0,
- 5000.0
+ 30.0,
+ 50.0
],
"PositiveHysteresis": 0,
"Reading": [
@@ -321,7 +321,7 @@
]
},
{
- "FailSafePercent": 90,
+ "FailSafePercent": 100,
"MinThermalRpm": 3000,
"Name": "Pid 1",
"Type": "Pid.Zone"
@@ -345,4 +345,4 @@
"PartNumber": "R2104",
"SerialNumber": "23165"
}
-}
\ No newline at end of file
+}
diff --git a/configurations/WFT Baseboard.json b/configurations/WFT Baseboard.json
index d23d545..879cd5d 100644
--- a/configurations/WFT Baseboard.json
+++ b/configurations/WFT Baseboard.json
@@ -856,19 +856,19 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -20.0,
- "ILimitMax": 7000,
- "ILimitMin": 3000,
+ "ICoefficient": -0.2,
+ "ILimitMax": 100,
+ "ILimitMin": 30,
"Inputs": [
"Core 0 CPU0"
],
"Name": "Core 0 CPU0",
- "OutLimitMax": 7000,
- "OutLimitMin": 3000,
+ "OutLimitMax": 100,
+ "OutLimitMin": 30,
"Outputs": [],
- "PCoefficient": -300.0,
+ "PCoefficient": -3.0,
"SetPoint": 45.0,
- "SlewNeg": -100,
+ "SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
"Zones": [
@@ -1345,4 +1345,4 @@
"PartNumber": "$PRODUCT_PART_NUMBER",
"SerialNumber": "$PRODUCT_SERIAL_NUMBER"
}
-}
\ No newline at end of file
+}