commit 9813279b57359bd1602da236ff7d38bcc9a2fba4
author James Feist <james.feist@linux.intel.com> Tue Jul 09 13:29:09 2019 -0700
committer James Feist <james.feist@linux.intel.com> Fri Jul 12 16:15:00 2019 +0000
tree 72ff44210b715c192d9f2aaeef1adfc9dc4cdaa2
parent 0b6b34f27fe24c768d663fe5e8155a1bc66f2fd3

Turn on a bunch of warnings

Turn on as many warnings as I could easily from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Tested: sensor list still the same

Change-Id: Ie7c56282e6a590a339554b40017b92020dd939f1
Signed-off-by: James Feist <james.feist@linux.intel.com>

src/Overlay.cpp

diff --git a/src/Overlay.cpp b/src/Overlay.cpp
index 3d30068..3877ff2 100644
--- a/src/Overlay.cpp
+++ b/src/Overlay.cpp
@@ -122,8 +122,6 @@
     std::filesystem::path devDir(I2C_DEVS_DIR);
     devDir /= std::to_string(busIndex) + "-" + hexAddress.str();
 
-    std::string channelName;
-
     for (std::size_t channelIndex = 0; channelIndex < channelNames.size();
          channelIndex++)
     {
@@ -248,7 +246,8 @@
     deviceFile.close();
     if (boost::ends_with(type, "Mux") && bus && address && channels)
     {
-        linkMux(name, *bus, *address, *channels);
+        linkMux(name, static_cast<size_t>(*bus), static_cast<size_t>(*address),
+                *channels);
     }
 }
 
@@ -277,7 +276,7 @@
         if (keyPair.key() == "Bus" &&
             keyPair.value().type() == nlohmann::json::value_t::string)
         {
-            unsigned int dec =
+            long unsigned int dec =
                 std::stoul(keyPair.value().get<std::string>(), nullptr, 16);
             subsituteString = std::to_string(dec);
         }