meta-facebook: yosemite4: Trigger failsafe for unavailable temp sensors
Summary:
Enable failsafe mode when certain temperature sensors are unavailable.
Description:
Removed "InputUnavailableAsFailed": false from selected temperature
sensor configurations in entity-manager. This change allows the system
to enter failsafe mode when those sensors are unavailable, improving
protection against potential thermal issues.
Note: Some sensors are expected to be unavailable during host DC-off or
before POST-complete. As such, increased fan activity during those
states is considered normal.
Motivation:
Requested by the Thermal team. Some critical sensors may fail to report
valid readings under certain conditions. Treating unavailability as a
non-failure could delay proper fan response and system protection.
Test Plan:
- Build and flash the firmware.
- Power cycle the system and check fan behavior in AC-off, DC-off, and
early boot stages.
- Simulate sensor unavailability and check failsafe mode is triggered.
Change-Id: If90b30cc28b3d10bdfdba69430d9f41a176c6efb
Signed-off-by: Patrick NC Lin <patrick.nc.lin.wiwynn@gmail.com>
diff --git a/configurations/meta/yosemite4_sentineldome_t1.json b/configurations/meta/yosemite4_sentineldome_t1.json
index 9a3572c..9780ac0 100644
--- a/configurations/meta/yosemite4_sentineldome_t1.json
+++ b/configurations/meta/yosemite4_sentineldome_t1.json
@@ -9,7 +9,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -45,7 +44,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -72,7 +70,6 @@
"ICoefficient": -0.03,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -99,7 +96,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
@@ -148,7 +144,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -168,7 +163,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"CALIBRATED_SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -216,7 +210,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -255,7 +248,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -291,7 +283,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -331,7 +322,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
diff --git a/configurations/meta/yosemite4_sentineldome_t1_retimer.json b/configurations/meta/yosemite4_sentineldome_t1_retimer.json
index 9599078..ec1d9e7 100644
--- a/configurations/meta/yosemite4_sentineldome_t1_retimer.json
+++ b/configurations/meta/yosemite4_sentineldome_t1_retimer.json
@@ -9,7 +9,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_X8_RTM_TEMP_C"
],
@@ -36,7 +35,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -72,7 +70,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -99,7 +96,6 @@
"ICoefficient": -0.03,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -126,7 +122,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
@@ -175,7 +170,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_X8_RTM_TEMP_C"
],
@@ -209,7 +203,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -229,7 +222,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"CALIBRATED_SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -277,7 +269,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -316,7 +307,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -352,7 +342,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -392,7 +381,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
diff --git a/configurations/meta/yosemite4_sentineldome_t2.json b/configurations/meta/yosemite4_sentineldome_t2.json
index 0f92669..b86b0dc 100644
--- a/configurations/meta/yosemite4_sentineldome_t2.json
+++ b/configurations/meta/yosemite4_sentineldome_t2.json
@@ -9,7 +9,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -47,7 +46,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -74,7 +72,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -101,7 +98,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_DATA_TEMP_C"
],
@@ -128,7 +124,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
@@ -177,7 +172,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -197,7 +191,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"CALIBRATED_SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -237,7 +230,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -296,7 +288,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -336,7 +327,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -372,7 +362,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_DATA_TEMP_C"
],
@@ -402,7 +391,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
diff --git a/configurations/meta/yosemite4_sentineldome_t2_retimer.json b/configurations/meta/yosemite4_sentineldome_t2_retimer.json
index e08d020..28e5699 100644
--- a/configurations/meta/yosemite4_sentineldome_t2_retimer.json
+++ b/configurations/meta/yosemite4_sentineldome_t2_retimer.json
@@ -9,7 +9,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_X8_RTM_TEMP_C"
],
@@ -36,7 +35,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -74,7 +72,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -101,7 +98,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -128,7 +124,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_DATA_TEMP_C"
],
@@ -155,7 +150,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
@@ -204,7 +198,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_X8_RTM_TEMP_C"
],
@@ -238,7 +231,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -258,7 +250,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"CALIBRATED_SENTINEL_DOME_SLOT $bus % 15 MB_FIO_TEMP_C"
],
@@ -298,7 +289,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 DIMM_A1_TEMP_C",
@@ -357,7 +347,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_CPU_TEMP_C"
],
@@ -397,7 +386,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_BOOT_TEMP_C"
],
@@ -433,7 +421,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_SSD_DATA_TEMP_C"
],
@@ -463,7 +450,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_CPU0_TEMP_C",
"SENTINEL_DOME_SLOT $bus % 15 MB_VR_SOC_TEMP_C",
diff --git a/configurations/meta/yosemite4_wailuafalls.json b/configurations/meta/yosemite4_wailuafalls.json
index 9aa8ba2..bc7df36 100644
--- a/configurations/meta/yosemite4_wailuafalls.json
+++ b/configurations/meta/yosemite4_wailuafalls.json
@@ -9,7 +9,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_VR_ASIC1_P0V8_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_VR_ASIC1_PVDDQ_CD_TEMP_C",
@@ -43,7 +42,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_MCIO4_DIMM_A1_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_MCIO4_DIMM_A0_TEMP_C",
@@ -77,7 +75,6 @@
"ICoefficient": -0.035,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_E1S_TEMP_C"
],
@@ -104,7 +101,6 @@
"ICoefficient": -0.02,
"ILimitMax": 100,
"ILimitMin": -50,
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_CXL1_CNTR_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_CXL2_CNTR_TEMP_C"
@@ -125,7 +121,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_VR_ASIC1_P0V8_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_VR_ASIC1_PVDDQ_CD_TEMP_C",
@@ -162,7 +157,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_MCIO4_DIMM_A1_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_MCIO4_DIMM_A0_TEMP_C",
@@ -199,7 +193,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_E1S_TEMP_C"
],
@@ -229,7 +222,6 @@
},
{
"Class": "temp",
- "InputUnavailableAsFailed": false,
"Inputs": [
"WAILUA_FALLS_SLOT $bus % 15 WF_CXL1_CNTR_TEMP_C",
"WAILUA_FALLS_SLOT $bus % 15 WF_CXL2_CNTR_TEMP_C"