commit c0da0cc858c36a530f308eec45e286ba92e35b6d
author Andrew Jeffery <andrew@aj.id.au> Wed Apr 13 18:15:09 2022 +0930
committer Ed Tanous <ed@tanous.net> Fri May 06 21:29:37 2022 +0000
tree 96339e013736fb79c89692f5f7a2002c1637d402
parent ba41b627b22cc9589df3963611632b1f819ed4d5

PerformScan: Rename fromLastJson in recordDiscoveredIdentifiers()

Now that we're freed from the caller context give it a name that
represents it the object in the context of the function.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie7c384b5f3fc9cc281c15193c150f383c3a295dd

src/PerformScan.cpp

diff --git a/src/PerformScan.cpp b/src/PerformScan.cpp
index f1f5f94..9c621a0 100644
--- a/src/PerformScan.cpp
+++ b/src/PerformScan.cpp
@@ -266,7 +266,7 @@
 static void recordDiscoveredIdentifiers(std::set<nlohmann::json>& usedNames,
                                         std::list<size_t>& indexes,
                                         const std::string& probeName,
-                                        const nlohmann::json& fromLastJson)
+                                        const nlohmann::json& record)
 {
     size_t indexIdx = probeName.find('$');
     if (indexIdx == std::string::npos)
@@ -274,8 +274,8 @@
         return;
     }
 
-    auto nameIt = fromLastJson.find("Name");
-    if (nameIt == fromLastJson.end())
+    auto nameIt = record.find("Name");
+    if (nameIt == record.end())
     {
         std::cerr << "Last JSON Illegal\n";
         return;