Update clamps with real I coeffs
Take coeffs from last generation and apply them. Also
autojson.
Change-Id: I21db30c090d7438c912e0a47a4a37bb37bd8470e
Signed-off-by: James Feist <james.feist@linux.intel.com>
diff --git a/configurations/WFT Baseboard.json b/configurations/WFT Baseboard.json
index cae8b36..2a4f07f 100644
--- a/configurations/WFT Baseboard.json
+++ b/configurations/WFT Baseboard.json
@@ -1674,7 +1674,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1687,7 +1687,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 80.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1701,7 +1701,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1728,7 +1728,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1754,7 +1754,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1781,7 +1781,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1808,7 +1808,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1835,7 +1835,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1863,7 +1863,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -8.8,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1876,7 +1876,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 55.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1890,7 +1890,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -8.8,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1903,7 +1903,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 55.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1917,7 +1917,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -4.64,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1930,7 +1930,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 76.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1944,7 +1944,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -8.8,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1957,7 +1957,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 90.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1971,7 +1971,7 @@
"Class": "temp",
"FFGainCoefficient": 0.0,
"FFOffCoefficient": 0.0,
- "ICoefficient": -1.0,
+ "ICoefficient": -8.8,
"ILimitMax": 100,
"ILimitMin": 30,
"Inputs": [
@@ -1984,7 +1984,7 @@
"Outputs": [],
"PCoefficient": -0.15,
"PositiveHysteresis": 0.0,
- "SetPoint": 60.0,
+ "SetPoint": 90.0,
"SlewNeg": -1,
"SlewPos": 0.0,
"Type": "Pid",
@@ -1996,52 +1996,6 @@
]
},
{
- "Address": "0x30",
- "Bus": 0,
- "CpuID": 1,
- "Name": "CPU 1",
- "Thresholds": [
- {
- "Direction": "greater than",
- "Label": "DIMM",
- "Name": "upper critical",
- "Severity": 1,
- "Value": 99
- },
- {
- "Direction": "greater than",
- "Label": "DIMM",
- "Name": "upper non critical",
- "Severity": 0,
- "Value": 89
- }
- ],
- "Type": "XeonCPU"
- },
- {
- "Address": "0x31",
- "Bus": 0,
- "CpuID": 2,
- "Name": "CPU 2",
- "Thresholds": [
- {
- "Direction": "greater than",
- "Label": "DIMM",
- "Name": "upper critical",
- "Severity": 1,
- "Value": 99
- },
- {
- "Direction": "greater than",
- "Label": "DIMM",
- "Name": "upper non critical",
- "Severity": 0,
- "Value": 89
- }
- ],
- "Type": "XeonCPU"
- },
- {
"Address": "0x4D",
"Bus": 6,
"Name": "Right Rear Board Temp",
@@ -2201,12 +2155,58 @@
}
],
"Type": "TMP75"
+ },
+ {
+ "Address": "0x30",
+ "Bus": 0,
+ "CpuID": 1,
+ "Name": "CPU 1",
+ "Thresholds": [
+ {
+ "Direction": "greater than",
+ "Label": "DIMM",
+ "Name": "upper critical",
+ "Severity": 1,
+ "Value": 99
+ },
+ {
+ "Direction": "greater than",
+ "Label": "DIMM",
+ "Name": "upper non critical",
+ "Severity": 0,
+ "Value": 89
+ }
+ ],
+ "Type": "XeonCPU"
+ },
+ {
+ "Address": "0x31",
+ "Bus": 0,
+ "CpuID": 2,
+ "Name": "CPU 2",
+ "Thresholds": [
+ {
+ "Direction": "greater than",
+ "Label": "DIMM",
+ "Name": "upper critical",
+ "Severity": 1,
+ "Value": 99
+ },
+ {
+ "Direction": "greater than",
+ "Label": "DIMM",
+ "Name": "upper non critical",
+ "Severity": 0,
+ "Value": 89
+ }
+ ],
+ "Type": "XeonCPU"
}
],
"Name": "WFP Baseboard",
"Probe": "xyz.openbmc_project.FruDevice({'PRODUCT_PRODUCT_NAME': '.*WFT'})",
- "Type": "Board",
"ProductId": 123,
+ "Type": "Board",
"xyz.openbmc_project.Inventory.Decorator.Asset": {
"Manufacturer": "$PRODUCT_MANUFACTURER",
"Model": "$PRODUCT_PRODUCT_NAME",