tree 8f2c8448900fc962fe331f713869cf77c0bb5232
parent 37e142be0f8062be893e9fdeba40df59f8674f90
author Ed Tanous <edtanous@google.com> 1620774166 -0700
committer Ed Tanous <edtanous@google.com> 1620774290 -0700

Make a copy of the probe string to fix warning

The newest version of gcc uncovered a subtle bug where we were relying
on a reference to an rvalue in a loop.  How this manifested was that
probeCommand was of type nlohmann::json, which has begin() and end()
overloads for std::string, but would return by value instead of by
reference to the nlohmann internals.  Because of this, technically the
reference we were looking at is destroyed each iteration of the loop.

This never caused an issue in practice, as the lifetime of probeCommand
was always greater than probe, but it's good to not rely on undefined
behavior.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie89df5d69236331de68788a7f3c5af862160c069