commit d45b1e7ea5fb1986e3c7c8b7d2c866cac38fec13
author Andrew Jeffery <andrew@aj.id.au> Tue Apr 12 22:47:14 2022 +0930
committer Ed Tanous <ed@tanous.net> Wed May 04 15:31:31 2022 +0000
tree f7e1dc9f406df700baa810c79f4984ac832dec39
parent ef5c84338555f11e2c5729f20df4b670f6d6a081

PerformScan: Promote dbusObject from pointer to reference

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia2094e141c0b2878e62dbd05884ca05e8bfe33ce

src/PerformScan.cpp

diff --git a/src/PerformScan.cpp b/src/PerformScan.cpp
index a4e2b74..b6a9c30 100644
--- a/src/PerformScan.cpp
+++ b/src/PerformScan.cpp
@@ -382,13 +382,10 @@
                     // interface, such as if it was just TRUE, then
                     // templateCharReplace will just get passed in an empty
                     // map.
-                    const DBusObject* dbusObject = &emptyObject;
-
                     auto ifacesIt = dbusSubtree.find(path);
-                    if (ifacesIt != dbusSubtree.end())
-                    {
-                        dbusObject = &ifacesIt->second;
-                    }
+                    const DBusObject& dbusObject =
+                        (ifacesIt == dbusSubtree.end()) ? emptyObject
+                                                        : ifacesIt->second;
 
                     nlohmann::json record = *recordPtr;
                     std::string recordName =
@@ -407,7 +404,7 @@
                     nlohmann::json copyForName = {{"Name", getName.value()}};
                     nlohmann::json::iterator copyIt = copyForName.begin();
                     std::optional<std::string> replaceVal = templateCharReplace(
-                        copyIt, *dbusObject, foundDeviceIdx, replaceStr);
+                        copyIt, dbusObject, foundDeviceIdx, replaceStr);
 
                     if (!replaceStr && replaceVal)
                     {
@@ -416,7 +413,7 @@
                             replaceStr = replaceVal;
                             copyForName = {{"Name", getName.value()}};
                             copyIt = copyForName.begin();
-                            templateCharReplace(copyIt, *dbusObject,
+                            templateCharReplace(copyIt, dbusObject,
                                                 foundDeviceIdx, replaceStr);
                         }
                     }
@@ -439,8 +436,8 @@
 
                             continue; // already covered above
                         }
-                        templateCharReplace(keyPair, *dbusObject,
-                                            foundDeviceIdx, replaceStr);
+                        templateCharReplace(keyPair, dbusObject, foundDeviceIdx,
+                                            replaceStr);
                     }
 
                     // insert into configuration temporarily to be able to
@@ -461,7 +458,7 @@
                              keyPair != expose.end(); keyPair++)
                         {
 
-                            templateCharReplace(keyPair, *dbusObject,
+                            templateCharReplace(keyPair, dbusObject,
                                                 foundDeviceIdx, replaceStr);
 
                             bool isBind =