commit efcbf00cf20927979476e68279c49b6dcd527ba1
author Andrew Jeffery <andrew@aj.id.au> Thu Apr 07 17:29:22 2022 +0930
committer Andrew Jeffery <andrew@aj.id.au> Wed Apr 13 16:18:29 2022 +0930
tree 9012d93835c8c1a5e00871124b56bcadf2f7124b
parent deb97f121edecd5c25ec034fbdda2460f1eef552

Utils: Use consistent style in expression reconstruction

Also avoid generation of intermediate strings where possible.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I42c5443d58cbc872a61e29b24581be118e3f02b5

src/Utils.cpp

diff --git a/src/Utils.cpp b/src/Utils.cpp
index 3d56946..308b082 100644
--- a/src/Utils.cpp
+++ b/src/Utils.cpp
@@ -306,15 +306,13 @@
         std::string replaced(find.begin(), find.end());
         while (exprBegin != exprEnd)
         {
-            replaced += " ";
-            replaced += *exprBegin++;
+            replaced.append(" ").append(*exprBegin++);
         }
-
         ret = replaced;
 
         while (exprEnd != split.end())
         {
-            result += " " + *exprEnd++;
+            result.append(" ").append(*exprEnd++);
         }
         keyPair.value() = result;