entity-manager: remove inventory manager interface
Remove the inventory manager interface added with fd1264a. It is a
barrier to entity-manager adoption in stacks using
phosphor-inventory-manager.
The rationale given for fd1264a was:
> This interface is used to identify demons that
> contain inventory, add the interface for lookups.
Identifying daemons that contain inventory can simply look for objects
in the /inventory path namespace. Performing lookups can be done in the
usual ways via the OpenBMC object mapper or entity-manager's
org.freedesktop.DBus.ObjectManager implementation.
The Manager interface documentation is ambiguous and open to
interpretation but the intent of the Manager interface seems to be for
applications that wish to "own" the lifecycle of inventory objects while
not hosting them, and the Notify method of the interface provides the
means for that. Entity manager does not attempt to meet this design
point at all (as is clearly indicated by the no-op Notify implementation
being removed) so there is little value in providing the interface.
Change-Id: I2b18e45c7b8c4e427ebb76a46c8070466d79e60d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/src/EntityManager.cpp b/src/EntityManager.cpp
index b1b5559..cab9e5e 100644
--- a/src/EntityManager.cpp
+++ b/src/EntityManager.cpp
@@ -1831,25 +1831,12 @@
objServer.add_interface("/xyz/openbmc_project/EntityManager",
"xyz.openbmc_project.EntityManager");
- std::shared_ptr<sdbusplus::asio::dbus_interface> inventoryIface =
- objServer.add_interface("/xyz/openbmc_project/inventory",
- "xyz.openbmc_project.Inventory.Manager");
-
// to keep reference to the match / filter objects so they don't get
// destroyed
std::vector<sdbusplus::bus::match::match> dbusMatches;
nlohmann::json systemConfiguration = nlohmann::json::object();
- inventoryIface->register_method(
- "Notify",
- [](const boost::container::flat_map<
- std::string,
- boost::container::flat_map<std::string, BasicVariantType>>&) {
- return;
- });
- inventoryIface->initialize();
-
io.post([&]() {
#if OVERLAYS
unloadAllOverlays();