commit 28cc834cecbd3d93e21089862a9288474b5f88cc
author John Edward Broadbent <jebr@google.com> Thu Apr 14 19:28:12 2022 -0700
committer John Edward Broadbent <jebr@google.com> Mon Apr 18 09:52:31 2022 -0700
tree 18c1d6c7742c6a43eddd14e5c869fb5c4c6541bf
parent 2b5454d316b564e63b6f5afa5e0018a014d81365

Add exception when constructor fails

We should fail as soon as we know the object had failed to init the
cryptdevice correctly. There is no logic to compensate this type of
failure.

Signed-off-by: John Edward Broadbent <jebr@google.com>
Change-Id: I4c4b3719840ef42d8ecf378410ff0788fb040b1a

include/cryptsetupInterface.hpp

diff --git a/include/cryptsetupInterface.hpp b/include/cryptsetupInterface.hpp
index 719e98b..0fb0c32 100644
--- a/include/cryptsetupInterface.hpp
+++ b/include/cryptsetupInterface.hpp
@@ -250,7 +250,9 @@
         int retval = crypt_init(&cryptDev, device);
         if (retval < 0)
         {
-            return nullptr;
+            lg2::error("Failed to crypt_init", "REDFISH_MESSAGE_ID",
+                       std::string("OpenBMC.0.1.InitFail"));
+            throw ResourceNotFound();
         }
 
         return cryptDev;