commit b2c86be3b1c6bf26dbfbcf3e3a3f3322472023e9
author John Edward Broadbent <jebr@google.com> Fri Apr 15 11:45:53 2022 -0700
committer John Edward Broadbent <jebr@google.com> Tue Apr 19 16:33:36 2022 -0700
tree 74820acae0d9fd50126c00753b9031565ec53033
parent 28cc834cecbd3d93e21089862a9288474b5f88cc

Change ownership of handle to eStorageD object

Clients used to create both the CryptHandle and the eStorageD objects
using the same information. Then the client would pass the CryptHandle
into eStorageD methods in order to perform crypto methods. This change
creates the CryptHandle closer to where it is used. This makes the code
simpler and easier to understand.

Tested:
busctl call xyz.openbmc_project.eStoraged.mmcblk0 \
>    /xyz/openbmc_project/inventory/storage/mmcblk0 \
>    xyz.openbmc_project.Inventory.Item.Volume FormatLuks ays 3 1 2 3 \
>    xyz.openbmc_project.Inventory.Item.Volume.FilesystemType.ext4 \
>    --timeout=60

Change-Id: I276e97146f4498191eb19512bc244a1e8d9cd2cb
Signed-off-by: John Edward Broadbent <jebr@google.com>

src/erase/cryptoErase.cpp

diff --git a/src/erase/cryptoErase.cpp b/src/erase/cryptoErase.cpp
index 426ba01..530ed8d 100644
--- a/src/erase/cryptoErase.cpp
+++ b/src/erase/cryptoErase.cpp
@@ -26,7 +26,7 @@
 void CryptErase::doErase()
 {
     /* get cryptHandle */
-    CryptHandle cryptHandle(std::string(devPath).c_str());
+    CryptHandle cryptHandle{devPath};
     /* cryptLoad */
     if (cryptIface->cryptLoad(cryptHandle.get(), CRYPT_LUKS2, nullptr) != 0)
     {