commit d8ef7b36a505286f7e3a41bd06f1a42127bb8da0
author Bonnie Lo <Bonnie_Lo@wiwynn.com> Mon Oct 24 16:42:42 2022 +0800
committer Patrick Williams <patrick@stwcx.xyz> Mon Oct 24 20:24:36 2022 +0000
tree 66572bf80431cd84f542d4568a7f845d88df1a6b
parent 3f6712731c3effe73d3d9474579f956522f4dde9

biccommands: post code handler

Revise the input parameters for OEM POST code handler so
that BMC could get all the POST code from BIC.

uint8_t interface -> uint8_t dataLen: represnts the length of received
                                      POST code
uint8_t data -> std::vector<uint8_t> data:receive all the POST code instead
                                          of specific POST code

Test Case:
Check POST code for multi-host

Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
Change-Id: I0d2db5173cc98819d19fd27db2bcb1f6b96e9bb3

src/biccommands.cpp

diff --git a/src/biccommands.cpp b/src/biccommands.cpp
index a1be5a6..0813593 100644
--- a/src/biccommands.cpp
+++ b/src/biccommands.cpp
@@ -73,45 +73,47 @@
 // netfn=0x38 and cmd=0x08 send the response back to the sender.
 //----------------------------------------------------------------------
 
-ipmi::RspType<std::array<uint8_t, 3>, uint8_t>
+ipmi::RspType<std::array<uint8_t, 3>>
     ipmiOemPostCodeHandler(ipmi::Context::ptr ctx, std::array<uint8_t, 3> iana,
-                           uint8_t interface, uint8_t data)
+                           uint8_t dataLen, std::vector<uint8_t> data)
 {
     // creating bus connection
     auto conn = getSdBus();
 
-    try
-    {
-        using postcode_t = std::tuple<uint64_t, std::vector<uint8_t>>;
+    using postcode_t = std::tuple<uint64_t, std::vector<uint8_t>>;
 
-        uint64_t primaryPostCode = static_cast<uint64_t>(data);
+    std::string dbusObjStr = dbusObj + std::to_string((ctx->hostIdx + 1));
+
+    for (unsigned int index = 0; index < dataLen; index++)
+    {
+        uint64_t primaryPostCode = static_cast<uint64_t>(data[index]);
         auto postCode = postcode_t(primaryPostCode, {});
 
-        // creating dbus objects for 1 to N process
-        std::string dbusObjStr = dbusObj + std::to_string((ctx->hostIdx + 1));
+        try
+        {
+            auto method = conn->new_method_call(
+                "xyz.openbmc_project.State.Boot.Raw", dbusObjStr.c_str(),
+                "org.freedesktop.DBus.Properties", "Set");
 
-        // creating method call to update postd value
-        auto method = conn->new_method_call(
-            "xyz.openbmc_project.State.Boot.Raw", dbusObjStr.c_str(),
-            "org.freedesktop.DBus.Properties", "Set");
+            // Adding paramters to method call
+            method.append(dbusService, "Value",
+                          std::variant<postcode_t>(postCode));
 
-        // Adding paramters to method call
-        method.append(dbusService, "Value", std::variant<postcode_t>(postCode));
+            // Invoke method call function
+            auto reply = conn->call(method);
+        }
 
-        // Invoke method call function
-        auto reply = conn->call(method);
+        catch (std::exception& e)
+        {
+            phosphor::logging::log<phosphor::logging::level::ERR>(
+                "post code handler error\n");
 
-        // sending the success response with headers
-        return ipmi::responseSuccess(iana, interface);
+            // sending the Error response
+            return ipmi::responseResponseError();
+        }
     }
-    catch (std::exception& e)
-    {
-        phosphor::logging::log<phosphor::logging::level::ERR>(
-            "post code handler error\n");
 
-        // sending the Error response
-        return ipmi::responseResponseError();
-    }
+    return ipmi::responseSuccess(iana);
 }
 
 [[maybe_unused]] static void registerBICFunctions(void)