commit aa3741208d161a744e5f469fd40c633f92fabaf3
author Patrick Venture <venture@google.com> Fri Mar 15 15:09:10 2019 -0700
committer Patrick Venture <venture@google.com> Mon Mar 25 08:42:18 2019 -0700
tree 9991a93e60fd7de987a12c2c782d4faf753ffc3c
parent bb90d4fd5361dede69735492f2744f7b64a9bf94

add handler logic to handle SysPsuHardReset

Add handler logic to handler for SysPsuHardReset such that it splits the
true IPMI processing from the business logic.

Tested: Only ran unit-tests (added new ones).
Change-Id: Id5dae85cbc54db7dee3cb5e62ed80c77ff3d5719
Signed-off-by: Patrick Venture <venture@google.com>

test/Makefile.am

diff --git a/test/Makefile.am b/test/Makefile.am
index df796d7..04b6836 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -30,3 +30,7 @@
 check_PROGRAMS += cpld_unittest
 cpld_unittest_SOURCES = cpld_unittest.cpp
 cpld_unittest_LDADD = $(top_builddir)/libsyscmds_common.la
+
+check_PROGRAMS += psu_unittest
+psu_unittest_SOURCES = psu_unittest.cpp
+psu_unittest_LDADD = $(top_builddir)/libsyscmds_common.la

test/handler_mock.hpp

diff --git a/test/handler_mock.hpp b/test/handler_mock.hpp
index a92606a..6eb929a 100644
--- a/test/handler_mock.hpp
+++ b/test/handler_mock.hpp
@@ -20,6 +20,7 @@
     MOCK_CONST_METHOD1(getCpldVersion,
                        std::tuple<std::uint8_t, std::uint8_t, std::uint8_t,
                                   std::uint8_t>(unsigned int));
+    MOCK_CONST_METHOD1(psuResetDelay, void(std::uint32_t));
 };
 
 } // namespace ipmi

test/psu_unittest.cpp

diff --git a/test/psu_unittest.cpp b/test/psu_unittest.cpp
new file mode 100644
index 0000000..d2c84b1
--- /dev/null
+++ b/test/psu_unittest.cpp
@@ -0,0 +1,50 @@
+#include "handler_mock.hpp"
+#include "main.hpp"
+#include "psu.hpp"
+
+#include <cstdint>
+#include <cstring>
+#include <vector>
+
+#include <gtest/gtest.h>
+
+#define MAX_IPMI_BUFFER 64
+
+using ::testing::Return;
+
+namespace google
+{
+namespace ipmi
+{
+
+TEST(PsuCommandTest, InvalidRequestLength)
+{
+    std::vector<std::uint8_t> request = {SysOEMCommands::SysPsuHardReset};
+    size_t dataLen = request.size();
+    std::uint8_t reply[MAX_IPMI_BUFFER];
+
+    HandlerMock hMock;
+    EXPECT_EQ(IPMI_CC_REQ_DATA_LEN_INVALID,
+              PsuHardReset(request.data(), reply, &dataLen, &hMock));
+}
+
+TEST(PsuCommandTest, ValidRequest)
+{
+    std::uint32_t delayValue = 0x45;
+    struct PsuResetRequest requestContents;
+    requestContents.subcommand = SysOEMCommands::SysPsuHardReset;
+    requestContents.delay = delayValue;
+
+    std::vector<std::uint8_t> request(sizeof(requestContents));
+    std::memcpy(request.data(), &requestContents, sizeof(requestContents));
+    size_t dataLen = request.size();
+    std::uint8_t reply[MAX_IPMI_BUFFER];
+
+    HandlerMock hMock;
+    EXPECT_CALL(hMock, psuResetDelay(delayValue));
+    EXPECT_EQ(IPMI_CC_OK,
+              PsuHardReset(request.data(), reply, &dataLen, &hMock));
+}
+
+} // namespace ipmi
+} // namespace google