commit fff986179723dc593bad8cc9c66bd4d99df7bfbe
author Patrick Venture <venture@google.com> Mon Nov 12 09:05:54 2018 -0800
committer Patrick Venture <venture@google.com> Sat Nov 17 19:18:23 2018 -0800
tree 4ecab6c21c73af78e40aeb2edcf38b45cd3bb5c0
parent 96b088a7d8d27b903169536c45ef673cbb5e14e1

Use more specific ipmi error codes

Most errors in the handler were returning an unsupported code and not a
more specific code articulating the failure.  Update the code to use
more specific errors.

Change-Id: I7f517d094245e8e1a6169f43582522889bb895d0
Signed-off-by: Patrick Venture <venture@google.com>

cpld.cpp

diff --git a/cpld.cpp b/cpld.cpp
index 3a65674..ad874b2 100644
--- a/cpld.cpp
+++ b/cpld.cpp
@@ -56,7 +56,7 @@
     {
         std::fprintf(stderr, "Invalid command length: %u\n",
                      static_cast<uint32_t>(*dataLen));
-        return IPMI_CC_INVALID;
+        return IPMI_CC_REQ_DATA_LEN_INVALID;
     }
 
     // reqBuf[0] is the subcommand.
@@ -77,7 +77,7 @@
     {
         std::fprintf(stderr, "Path: '%s' doesn't exist.\n",
                      opath.str().c_str());
-        return IPMI_CC_INVALID;
+        return IPMI_CC_INVALID_FIELD_REQUEST;
     }
     // We're uninterested in the state of ec.
 
@@ -92,7 +92,7 @@
     }
     catch (std::ios_base::failure& fail)
     {
-        return IPMI_CC_INVALID;
+        return IPMI_CC_UNSPECIFIED_ERROR;
     }
 
     // If value parses as expected, return version.
@@ -106,7 +106,7 @@
     if (num_fields == 0)
     {
         std::fprintf(stderr, "Invalid version.\n");
-        return IPMI_CC_INVALID;
+        return IPMI_CC_UNSPECIFIED_ERROR;
     }
 
     // Truncate if the version is too high (documented).