Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / hiomapd / 59ce099b7b59e86f2cc8ffedd3c97143dfccd33c
commit59ce099b7b59e86f2cc8ffedd3c97143dfccd33c[log] [tgz]
authorJayanth Othayoth <ojayanth@in.ibm.com>Fri Oct 27 00:45:53 2017 -0500
committerJayanth Othayoth <ojayanth@in.ibm.com>Tue Oct 31 01:31:03 2017 -0500
tree645f092327fbcf656573bf31de8ff53701be80dc
parent8493c33b1adbaf0adaa6bf2b7c1696e86a89ab1b [diff]
Fix for mboxd segfault during flash read

mboxd segfaults during flash read when there is
no partition associated to the given offset within the
flash size.

Proposed fix is to generate elog instead of returning
reference to zeroed out pnor_partition structure.

Resolves openbmc/openbmc#2365

Change-Id: I98bed1c09588c386d9ea2510618bb27eaa6dfbe0
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
2 files changed
tree: 645f092327fbcf656573bf31de8ff53701be80dc
  1. Documentation/
  2. m4/
  3. test/
  4. xyz/
  5. .gitignore
  6. bootstrap.sh
  7. common.c
  8. common.h
  9. configure.ac
  10. dbus.h
  11. LICENSE
  12. Makefile.am
  13. mbox.h
  14. mboxctl.c
  15. mboxd.c
  16. mboxd_dbus.c
  17. mboxd_dbus.h
  18. mboxd_flash.h
  19. mboxd_flash_physical.c
  20. mboxd_flash_virtual.cpp
  21. mboxd_lpc.c
  22. mboxd_lpc.h
  23. mboxd_lpc_physical.c
  24. mboxd_lpc_virtual.cpp
  25. mboxd_msg.c
  26. mboxd_msg.h
  27. mboxd_pnor_partition_table.cpp
  28. mboxd_pnor_partition_table.h
  29. mboxd_windows.c
  30. mboxd_windows.h
  31. mtd.c
  32. pnor_partition.cpp
  33. pnor_partition.hpp
  34. pnor_partition_defs.h
  35. pnor_partition_table.cpp
  36. pnor_partition_table.hpp
  37. README.md
README.md

Copyright 2017 IBM

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

MBOX

This repo contains the protocol definition for the host to BMC mailbox communication specification which can be found in Documentation/mbox_procotol.md.

There is also a reference implementation of a BMC mailbox daemon, the details of which can be found in Documentation/mboxd.md.

Finally there is also an implementation of a mailbox daemon control program, the details of which can be found in Documentation/mboxctl.md.