commit b8d89b777e5e2c4242802b4554818f65a5fadf1a
author Ninad Palsule <ninad@linux.ibm.com> Wed Oct 23 11:15:21 2024 -0500
committer Ninad Palsule <ninad@linux.ibm.com> Tue Nov 05 08:44:35 2024 -0600
tree 85c9648900aea769845afc9bed4b1f7739102d45
parent 7841c825a051e6df076eb832649fb33fb7c512c9

vpnor: Improve error logging

We are seeing lot of crashes in the mboxd so hardening error logging to
figure out failure cases.
- Add missing error logs.
- Differentiate similar errors.

Change-Id: If56f77aed1d1d07cca1d108bc943bddc7216e579
Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>

vpnor/backend.cpp

diff --git a/vpnor/backend.cpp b/vpnor/backend.cpp
index 606acee..3866c57 100644
--- a/vpnor/backend.cpp
+++ b/vpnor/backend.cpp
@@ -90,7 +90,7 @@
     }
     catch (vpnor::TocEntryError& e)
     {
-        MSG_ERR("%s\n", e.what());
+        MSG_ERR("vpnor init: %s\n", e.what());
         try
         {
             phosphor::logging::commit<err::InternalFailure>();
@@ -172,7 +172,7 @@
     }
     catch (vpnor::ReasonedError& e)
     {
-        MSG_ERR("%s\n", e.what());
+        MSG_ERR("vpnor part copy: %s\n", e.what());
         phosphor::logging::commit<err::InternalFailure>();
         return -EIO;
     }
@@ -192,6 +192,7 @@
           fs::is_directory(fs::status(paths->rw_loc)) &&
           fs::is_directory(fs::status(paths->prsv_loc))))
     {
+        MSG_ERR("Couldn't find partition path\n");
         return -EINVAL;
     }
 
@@ -328,7 +329,7 @@
     }
     catch (std::exception& e)
     {
-        MSG_ERR("%s\n", e.what());
+        MSG_ERR("vpnor copy: %s\n", e.what());
         phosphor::logging::commit<err::InternalFailure>();
         rc = -EIO;
     }
@@ -385,12 +386,12 @@
     }
     catch (const vpnor::OutOfBoundsOffset& e)
     {
-        MSG_ERR("%s\n", e.what());
+        MSG_ERR("vpnor write: %s\n", e.what());
         return -EINVAL;
     }
     catch (const std::exception& e)
     {
-        MSG_ERR("%s\n", e.what());
+        MSG_ERR("vpnor write exception: %s\n", e.what());
         phosphor::logging::commit<err::InternalFailure>();
         return -EIO;
     }
@@ -419,13 +420,15 @@
         const pnor_partition& part = priv->vpnor->table->partition(offset);
         if (vpnor_partition_is_readonly(part))
         {
-            MSG_DBG("Try to write read only partition (part=%s, offset=0x%x)\n",
+            MSG_ERR("Try to write read only partition (part=%s, offset=0x%x)\n",
                     part.data.name, offset);
             return -EPERM;
         }
     }
     catch (const openpower::virtual_pnor::UnmappedOffset& e)
     {
+        MSG_ERR("Try to write unmapped area (offset=0x%lx)\n", e.base);
+
         /*
          * Writes to unmapped areas are not meaningful, so deny the request.
          * This removes the ability for a compromised host to abuse unused
@@ -496,6 +499,8 @@
     }
     catch (const openpower::virtual_pnor::UnmappedOffset& e)
     {
+        MSG_ERR("Aligned offset is unmapped area (offset=0x%lx)\n", e.base);
+
         /*
          * Writes to unmapped areas are not meaningful, so deny the request.
          * This removes the ability for a compromised host to abuse unused