commit e4cf6ac8d9ae6a1398b9f3510ac4939de0148001
author Andrew Jeffery <andrew@aj.id.au> Fri Mar 02 09:05:01 2018 +1030
committer Andrew Jeffery <andrew@aj.id.au> Sat Mar 24 13:59:32 2018 +1030
tree 31bf14c30f1d87c147a4a0a3d3b07efb0b44ed7f
parent fe5cc8f6af4a17cda55d4c4d05c5a193023b9cdf

mboxd_pnor_partition_table: Avoid using strcpy

Instead use strncpy() and specify the size of the destination buf, then
null-terminate the result.

Change-Id: I02b50010d4ba11feed5a96f27b3ec2bb50b2eabf
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_pnor_partition_table.cpp

diff --git a/mboxd_pnor_partition_table.cpp b/mboxd_pnor_partition_table.cpp
index decf048..49afeb0 100644
--- a/mboxd_pnor_partition_table.cpp
+++ b/mboxd_pnor_partition_table.cpp
@@ -21,10 +21,14 @@
     {
         int rc;
 
-        strcpy(context->paths.ro_loc, PARTITION_FILES_RO_LOC);
-        strcpy(context->paths.rw_loc, PARTITION_FILES_RW_LOC);
-        strcpy(context->paths.prsv_loc, PARTITION_FILES_PRSV_LOC);
-        strcpy(context->paths.patch_loc, PARTITION_FILES_PATCH_LOC);
+        strncpy(context->paths.ro_loc, PARTITION_FILES_RO_LOC, PATH_MAX);
+        context->paths.ro_loc[PATH_MAX - 1] = '\0';
+        strncpy(context->paths.rw_loc, PARTITION_FILES_RW_LOC, PATH_MAX);
+        context->paths.rw_loc[PATH_MAX - 1] = '\0';
+        strncpy(context->paths.prsv_loc, PARTITION_FILES_PRSV_LOC, PATH_MAX);
+        context->paths.prsv_loc[PATH_MAX - 1] = '\0';
+        strncpy(context->paths.patch_loc, PARTITION_FILES_PATCH_LOC, PATH_MAX);
+        context->paths.prsv_loc[PATH_MAX - 1] = '\0';
 
         rc = vpnor_create_partition_table_from_path(context,
                                                     PARTITION_FILES_RO_LOC);