sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7adbc8df11fa75f33f7d3437ea5ceae4ea6ca9d2
diff --git a/callout.cpp b/callout.cpp
index 3f409f9..1d95036 100644
--- a/callout.cpp
+++ b/callout.cpp
@@ -83,7 +83,7 @@
Callout::Callout(sdbusplus::bus::bus& bus, const std::string& objectPath,
size_t id, uint64_t timestamp) :
- CalloutObject(bus, objectPath.c_str(), true),
+ CalloutObject(bus, objectPath.c_str(), CalloutObject::action::defer_emit),
entryID(id), timestamp(timestamp)
{
}
@@ -91,7 +91,7 @@
Callout::Callout(sdbusplus::bus::bus& bus, const std::string& objectPath,
const std::string& inventoryPath, size_t id,
uint64_t timestamp, const DbusPropertyMap& properties) :
- CalloutObject(bus, objectPath.c_str(), true),
+ CalloutObject(bus, objectPath.c_str(), CalloutObject::action::defer_emit),
entryID(id), timestamp(timestamp)
{
path(inventoryPath);
diff --git a/manager.cpp b/manager.cpp
index aa8d5e0..4c8e4a0 100644
--- a/manager.cpp
+++ b/manager.cpp
@@ -164,7 +164,8 @@
{
auto values = policy::find(policies, properties);
- auto object = std::make_shared<PolicyObject>(bus, objectPath.c_str(), true);
+ auto object = std::make_shared<PolicyObject>(
+ bus, objectPath.c_str(), PolicyObject::action::defer_emit);
object->eventID(std::get<policy::EIDField>(values));
object->description(std::get<policy::MsgField>(values));